Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from the Web : country codes mapping #2883

Closed
ThierryClavel opened this issue May 5, 2022 · 1 comment · Fixed by #3320
Closed

Import from the Web : country codes mapping #2883

ThierryClavel opened this issue May 5, 2022 · 1 comment · Fixed by #3320
Assignees
Labels
enhancement Improvement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data

Comments

@ThierryClavel
Copy link

ThierryClavel commented May 5, 2022

How it works

some country codes (field 008/15-17) may be obsolete in imported MARC records. They are not present in RERO ILS (cf : #2881

Improvement suggestion

map the following obsolete codes to updated codes present in RERO ILS
To do for MARC21 catalogues (SLSP, LoC, DNB, etc.)
#: rero_ils/jsonschemas/common/countries-v0.0.1.json:

-cn Canada (json 633) > xxc (json:1885)
-err Estonia (json 737) > er (json 733)
-lir Lithuania (json 1057) > li (json 1053)
-lvr Latvia (json 1081) > lv (json 1077)
-uk United Kingdom (json 1661) > xxk (json:1889)
-unr Ukraine (json 1669) > un (json 1665)
-us United States (json:1681) > xxu (json:1897)
-ur Soviet Union (json 1677) > -xxr (json:1893)
-ys Yemen (People's Democratic Republic)(json:1909) > ye (json:1901)

@ThierryClavel ThierryClavel added enhancement Improvement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data p-Low Low priority labels May 5, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Nov 2, 2022
@github-actions github-actions bot closed this as completed Nov 2, 2022
@PascalRepond PascalRepond removed the stale Stale or no longer relevant label Nov 2, 2022
@PascalRepond PascalRepond reopened this Nov 2, 2022
@PascalRepond PascalRepond removed the p-Low Low priority label Mar 30, 2023
@PascalRepond PascalRepond moved this to Project Backlog in RERO ILS issues Mar 30, 2023
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 25, 2023
* Closes rero#2881.
* Closes rero#2883.

* ⚠️ Requires migration script to update obsolete country codes
(see mapping in this commit) to accepted ones in:
    * `document.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
    * `library.addres_block.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 25, 2023
* Closes rero#2881.
* Closes rero#2883.

* ⚠️ Requires migration script to update obsolete country codes
(see mapping in this commit) to accepted ones in:
    * `document.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
    * `library.billing_informations.address.country`
    * `library.shipping_informations.address.country`
@PascalRepond PascalRepond moved this from Product Backlog to In Development in RERO ILS issues Apr 25, 2023
@PascalRepond PascalRepond self-assigned this Apr 25, 2023
@PascalRepond PascalRepond moved this from In Development to Ready to test in RERO ILS issues Apr 26, 2023
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 26, 2023
* Closes rero#2881.
* Closes rero#2883.

* ⚠️ Requires migration script to update obsolete country codes
(see mapping in this commit) to accepted ones in:
    * `document.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
    * `library.billing_informations.address.country`
    * `library.shipping_informations.address.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 26, 2023
* Closes rero#2881.
* Closes rero#2883.

* ⚠️ Requires migration script to update obsolete country codes
(see mapping in this commit) to accepted ones in:
    * `document.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
    * `library.billing_informations.address.country`
    * `library.shipping_informations.address.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 27, 2023
* Closes rero#2881.
* Closes rero#2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 27, 2023
* Closes rero#2881.
* Closes rero#2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 27, 2023
* Closes rero#2881.
* Closes rero#2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 27, 2023
* Closes rero#2881.
* Closes rero#2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 27, 2023
* Closes rero#2881.
* Closes rero#2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 27, 2023
* Closes rero#2881.
* Closes rero#2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 27, 2023
* Closes rero#2881.
* Closes rero#2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 27, 2023
* Closes rero#2881.
* Closes rero#2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 27, 2023
* Closes rero#2881.
* Closes rero#2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Apr 27, 2023
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Apr 27, 2023
* Closes rero#2881.
* Closes rero#2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
@github-project-automation github-project-automation bot moved this from In testing to Done in RERO ILS issues May 2, 2023
PascalRepond added a commit that referenced this issue May 2, 2023
* Closes #2881.
* Closes #2883.
* Adds alembic script to upgrade countries in:
    * `document.place.provisionActivity.country`
    * `patron.second_address.country`
    * `user.country`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants