Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user form validations #2765

Closed
jma opened this issue Mar 15, 2022 · 0 comments · Fixed by #2861
Closed

Add user form validations #2765

jma opened this issue Mar 15, 2022 · 0 comments · Fixed by #2861
Assignees
@zannkukai
Labels
bug Breaks something but is not blocking dev: sentry For PRs that are created to correct an error raised by Sentry. f: professional ui Professional interface f: user management p-Medium Medium priority (to be solved within 1-2 years) production Issue specifically spotted on the production server

Comments

@jma
Copy link
Contributor

jma commented Mar 15, 2022 •
edited by PascalRepond
Loading

Bug description:

The form to create or edit a user do not contains enough validation: this can cause and database error. I.e. long postal code. See sentry: https://sentryils.rero.ch:8443/share/issue/527d34f744a94555b152418b3b14b5e5/ for more details.

Expected behavior:

It should not be possible to push non valid data.
Note: other validation should be fixed:

  • submit a patron without a barcode,
  • submit a form with a communication email without email defined either in the user profile or the patron metadata.
  • Validate email format ! I can currently save a completely wrong format :
    image

Steps to Reproduce:

Server:

Version:

v1.9.0 ; commit hash : XXXX

Browser:

Chrome, Safari, Firefox; version XX

Screenshots

Anything else?
@jma jma added the bug Breaks something but is not blocking label Mar 15, 2022
@PascalRepond PascalRepond added f: professional ui Professional interface f: user management production Issue specifically spotted on the production server dev: monitoring Alert system like Sentry or Zabbix. p-Medium Medium priority (to be solved within 1-2 years) labels Mar 15, 2022
@PascalRepond PascalRepond added dev: sentry For PRs that are created to correct an error raised by Sentry. and removed dev: monitoring Alert system like Sentry or Zabbix. labels Apr 12, 2022
@PascalRepond PascalRepond mentioned this issue Apr 12, 2022
Closed
@zannkukai zannkukai self-assigned this Apr 21, 2022
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 27, 2022
@zannkukai
resource: improve data validation against JSONSchema
8bfeae8 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai mentioned this issue Apr 27, 2022
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Apr 28, 2022
@zannkukai
resource: improve data validation against JSONSchema
e38eed8 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 4, 2022
@zannkukai
resource: improve data validation against JSONSchema
6456377 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 4, 2022
@zannkukai
resource: improve data validation against JSONSchema
57a691b 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 16, 2022
@zannkukai
resource: improve data validation against JSONSchema
4b4a553 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 16, 2022
@zannkukai
resource: improve data validation against JSONSchema
aaab120 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 16, 2022
@zannkukai
resource: improve data validation against JSONSchema
19eba83 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 17, 2022
@zannkukai
resource: improve data validation against JSONSchema
168f0f7 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 17, 2022
@zannkukai
resource: improve data validation against JSONSchema
ccdbb82 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 20, 2022
@zannkukai
resource: improve data validation against JSONSchema
6c87df9 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue May 25, 2022
@zannkukai
resource: improve data validation against JSONSchema
b1430ed 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes #2765.
* Closes #2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 31, 2022
@zannkukai
resource: improve data validation against JSONSchema
ae96a49 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue May 31, 2022
@zannkukai
resource: improve data validation against JSONSchema
ba23be1 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes #2765.
* Closes #2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue May 31, 2022
@zannkukai
resource: improve data validation against JSONSchema
932a475 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes rero#2765.
* Closes rero#2838.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit that referenced this issue Jun 1, 2022
@zannkukai
resource: improve data validation against JSONSchema
6ad32e1 
* Adds a better 'email' format validation for all RERO-ILS resources.
* Simplify JSON schema defining fields with 'email' format.
* Adds length constraints for some `User` resource fields.
* Closes #2765.
* Closes #2838.

Co-Authored-by: Renaud Michotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
bug Breaks something but is not blocking dev: sentry For PRs that are created to correct an error raised by Sentry. f: professional ui Professional interface f: user management p-Medium Medium priority (to be solved within 1-2 years) production Issue specifically spotted on the production server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resource: improve data validation against JSONSchema zannkukai/rero-ils
3 participants
@jma @zannkukai @PascalRepond