Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item tasks: temporary locations are not cleaned correctly #2694

Closed
PascalRepond opened this issue Feb 10, 2022 · 2 comments · Fixed by #2790
Closed

Item tasks: temporary locations are not cleaned correctly #2694

PascalRepond opened this issue Feb 10, 2022 · 2 comments · Fixed by #2790
Assignees
@BadrAly
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries effort: 1pt 1 point of effort estimated for the implementation f: activity-logs Everything around logging user or system activities p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.10.0

Comments

@PascalRepond
Copy link
Contributor

Describe the bug

The daily task rero_ils.modules.items.tasks.clean_obsolete_temporary_item_types doesn't seem to work as intended. It runs without errors but temporary location in items remains after its due date.

To Reproduce

  1. Set a temporary location for an item with a deletion date
  2. After the deletion date is passed, the item still has its temporary location

Expected behavior

Temporary locations with overdue deletion dates should be deleted daily by the system.

Context
@PascalRepond PascalRepond added triage bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) f: activity-logs Everything around logging user or system activities labels Feb 10, 2022
@pronguen pronguen removed the triage label Feb 10, 2022
@pronguen pronguen added this to the v1.10.0 milestone Feb 21, 2022
@pronguen pronguen added the effort: 1pt 1 point of effort estimated for the implementation label Feb 22, 2022
@PascalRepond PascalRepond added the client request Issue reported by production libraries label Mar 8, 2022
@BadrAly BadrAly self-assigned this Mar 10, 2022
@BadrAly
Copy link

BadrAly commented Mar 11, 2022 •
edited
Loading

@PascalRepond Currently, we have only implemented task to delete the expired temporary_item_types-> clean_obsolete_temporary_item_types. Do you want to extend this functionality to delete the expired temoprary_locations? I assume that the removal of the expired temporary_item_types works fine and the problem is only with the temoprary_locations. Please confirm.

@PascalRepond
Copy link
Contributor Author

PascalRepond commented Mar 11, 2022 •
edited
Loading

@BadrAly OK, yes this functionnality should be extended to temporary_locations as well. I cannot confirm yet if it works with temporary_item_types but I am testing it.
In any case, if a deletion task for temporary_location is not implemented, it should be. Thank you.

BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 29, 2022
items: delete obsolete temporary locations
9d3babd 
* Indexes the field item.temporary_location.end_date.
* Closes rero#2694

Co-Authored-by: Aly Badr <[email protected]>
@BadrAly BadrAly mentioned this issue Mar 29, 2022
Merged
7 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 29, 2022
items: delete obsolete temporary locations
ad9b802 
* Indexes the field item.temporary_location.end_date.
* Closes rero#2694

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 29, 2022
items: delete obsolete temporary locations
db99223 
* Indexes the field item.temporary_location.end_date.
* Closes rero#2694

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 29, 2022
items: delete obsolete temporary locations
357eae2 
* Indexes the field item.temporary_location.end_date.
* Closes rero#2694

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 30, 2022
items: delete obsolete temporary locations
a7e3cf7 
* Indexes the field item.temporary_location.end_date.
* Closes rero#2694

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 30, 2022
items: delete obsolete temporary locations
61ac11e 
* Indexes the field item.temporary_location.end_date.
* Closes rero#2694

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 30, 2022
items: delete obsolete temporary locations
fdd1961 
* Indexes the field item.temporary_location.end_date.
* Closes rero#2694

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Mar 30, 2022
items: delete obsolete temporary locations
83dbf0c 
* Indexes the field item.temporary_location.end_date.
* Closes rero#2694

Co-Authored-by: Aly Badr <[email protected]>
BadrAly pushed a commit that referenced this issue Mar 31, 2022
items: delete obsolete temporary locations
a1439ba 
* Indexes the field item.temporary_location.end_date.
* Closes #2694

Co-Authored-by: Aly Badr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BadrAly BadrAly

Labels
bug Breaks something but is not blocking client request Issue reported by production libraries effort: 1pt 1 point of effort estimated for the implementation f: activity-logs Everything around logging user or system activities p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

items: delete obsolete temporary locations BadrAly/rero-ils
3 participants
@pronguen @BadrAly @PascalRepond