Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date checkout: sunday displayed as an opened day #2370

Closed
ManaDeweerdt opened this issue Sep 7, 2021 · 0 comments · Fixed by rero/rero-ils-ui#971
Closed

Fix date checkout: sunday displayed as an opened day #2370

ManaDeweerdt opened this issue Sep 7, 2021 · 0 comments · Fixed by rero/rero-ils-ui#971
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend UX User experience, ergonomy

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Sep 7, 2021 •
edited by iGormilhit
Loading

Describe the bug

In the calendar used for the fixed date checkout, Sunday is always set to be open even if it is a closing day for the library.
Note: Even if the librarian selects Sunday as a due date, the due date is calculated correctly to Monday.

To Reproduce

  1. Set the Sunday to close
  2. Make a fix date checkout.
  3. Chose a due date

Expected behavior

If Sunday is a closing day, it shouldn't be possible to select it as a due date.

Context

Screenshots

image
@ManaDeweerdt ManaDeweerdt added f: circulation Concerns the circulation interface or backend triage bug Breaks something but is not blocking p-Low Low priority labels Sep 7, 2021
@ManaDeweerdt ManaDeweerdt changed the title Fix date checkout: Sunday like an opened day Fix date checkout: Sunday displayed as an opened day Sep 8, 2021
@iGormilhit iGormilhit changed the title Fix date checkout: Sunday displayed as an opened day Fix date checkout: sunday displayed as an opened day Sep 21, 2021
@iGormilhit iGormilhit added UX User experience, ergonomy and removed triage labels Sep 21, 2021
@PascalRepond PascalRepond added p-Medium Medium priority (to be solved within 1-2 years) and removed p-Low Low priority labels Mar 9, 2023
@PascalRepond PascalRepond removed the p-Medium Medium priority (to be solved within 1-2 years) label Mar 30, 2023
@PascalRepond PascalRepond moved this to Project Backlog in RERO ILS issues Mar 30, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 12, 2023
@Garfield-fr
circulation: fix fixed date sunday not disabled
dcbaaf9 
Sunday was not disabled in the fixed Date Loan dialog.

* Closes rero/rero-ils#2370.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Apr 12, 2023
Merged
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 12, 2023
@Garfield-fr
circulation: fix fixed date sunday not disabled
60a2e5a 
Sunday was not disabled in the fixed Date Loan dialog.

* Closes rero/rero-ils#2370.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr moved this from Product Backlog to Ready to test in RERO ILS issues Apr 12, 2023
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Apr 12, 2023
@Garfield-fr
circulation: fix fixed date sunday not disabled
b7b0956 
Sunday was not disabled in the fixed Date Loan dialog.

* Closes rero/rero-ils#2370.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr self-assigned this Apr 12, 2023
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Apr 17, 2023
PascalRepond pushed a commit to rero/rero-ils-ui that referenced this issue Apr 17, 2023
@Garfield-fr @PascalRepond
circulation: fix fixed date sunday not disabled
2f75f02 
Sunday was not disabled in the fixed Date Loan dialog.

* Closes rero/rero-ils#2370.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Apr 19, 2023
@Garfield-fr
circulation: fix fixed date sunday not disabled
0699008 
Sunday was not disabled in the fixed Date Loan dialog.

* Closes rero/rero-ils#2370.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@github-project-automation github-project-automation bot moved this from In testing to Done in RERO ILS issues Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend UX User experience, ergonomy
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

circulation: fix fixed date sunday not disabled Garfield-fr/rero-ils-ui
4 participants
@Garfield-fr @iGormilhit @ManaDeweerdt @PascalRepond