Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fee counter not correct in the patron account (public interface) #2319

Closed
pronguen opened this issue Aug 23, 2021 · 1 comment · Fixed by rero/rero-ils-ui#721
Closed

Fee counter not correct in the patron account (public interface) #2319

pronguen opened this issue Aug 23, 2021 · 1 comment · Fixed by rero/rero-ils-ui#721
Assignees
@Garfield-fr
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: public ui Public interface, as opposed to the professional interface f: user management p-Medium Medium priority (to be solved within 1-2 years)

Comments

@pronguen
Copy link
Contributor

Describe the bug

Fee counter not correct in the patron account (public interface). It does not correspond to the fees listed in the tab.

To Reproduce

  1. Find a patron with fees
  2. Compare the professional and the public patron account

Expected behavior

Display is consistent between the 2 interfaces

Context

Screenshots

image
@pronguen pronguen added f: circulation Concerns the circulation interface or backend f: public ui Public interface, as opposed to the professional interface f: user management bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) labels Aug 23, 2021
@iGormilhit
Copy link

The facet parameter is missing in the following query: https://bib.rero.ch/api/loans/?q=patron_pid:220427 AND (state:ITEM_RETURNED OR state:ITEM_IN_TRANSIT_TO_HOUSE OR state:CANCELLED) AND _exists_:end_date&page=1&size=1&facets=

@Garfield-fr Garfield-fr self-assigned this Oct 7, 2021
@iGormilhit iGormilhit added this to the v1.7.0 milestone Oct 12, 2021
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 14, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
a55d3ab 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Oct 14, 2021
Merged
7 tasks
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 14, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
93560e1 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 20, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
67ac685 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 20, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
3d5690e 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 21, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
01df043 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 21, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
5464408 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 21, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
4de2a68 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 21, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
d9c89ea 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 21, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
cbd6be1 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 21, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
706e819 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 21, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
655dd3a 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Oct 21, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
72353f5 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to rero/rero-ils-ui that referenced this issue Oct 21, 2021
@Garfield-fr
patrons: restore fee count and refactoring patron history
9ab1934 
* Fixes count on fees tab and total on header.
* Uses the `operation logs` inex to display the patron history.
* Closes rero/rero-ils#2319.
* Closes rero/rero-ils#1902.
* Closes rero/rero-ils#1227.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Garfield-fr Garfield-fr

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: public ui Public interface, as opposed to the professional interface f: user management p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

patrons: restore fee count and refactoring patron history Garfield-fr/rero-ils-ui
3 participants
@Garfield-fr @iGormilhit @pronguen