Wrong pick-up location name in the booking notification

[pronguen]

Describe the bug

Some booking notifications have the wrong pick-up location name. It seems that the pick-up name to be inserted in the notification is taken in a previous loan instead of the current loan.

To Reproduce

1. Choose an item
2. Add a request for patron A with pick-up location A -> a correct request notification is sent
3. Add a request for patron B with pick-up location B
4. Add a request for patron C with pick-up location C
5. Check-out the item for patron A
6. Check-in the item and see the generated booking notification: it has A as pick-up location
7. If you do a checkout for B and then a checkin, see that the new booking notification still has A as pick-up location

Expected behavior

The pick-up location name in the notification is correct.

Context

• server: bib.rero.ch
• version: v1.4.6

Example

Date: 2 août 2021, 15:21:17

Titre: Chut pas un bruit ! (dragon endormi) / [texte] Bianca Schulze

Code-barre: 1012321218
Localisation: VOUVRY - Bibliothèque municipale et scolaire / Albums enfants
Cote: SCHU

Lieu de retrait: Vouvry - Bibliothèque municipale et scolaire
Lecteur: 2011014071

Concerns

• these circulation operations: https://bib.rero.ch/api/operation_logs/?q=loan.pid:172524%20AND%20loan.patron.pid:24430
• this item: https://bib.rero.ch/api/items/3076865