Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX of date exceptions #223

Closed
pronguen opened this issue Mar 18, 2019 · 1 comment
Closed

UX of date exceptions #223

pronguen opened this issue Mar 18, 2019 · 1 comment

Comments

@pronguen
Copy link
Contributor

Improve UX of date exceptions:

  1. For a "one day" exception, the exception cannot be saved if it is not repeated
  2. For a "one day" exception, the repeat option "every 1 day" should be disabled as it makes sense only if there is an end to the exception.
  3. Clarify the button "Days period" and align it with the ON/OFF option. Example: "The exception last more than one day: ON/OFF"
@pronguen pronguen added this to the JR-2019 milestone Mar 18, 2019
@iGormilhit iGormilhit removed this from the JR-2019 milestone Mar 25, 2019
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 2, 2019
@Garfield-fr
library exceptions date: improvement
4d36393 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Apr 2, 2019
Closed
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 2, 2019
@Garfield-fr
library exceptions date: improvement
f637dac 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 2, 2019
@Garfield-fr
library exceptions date: improvement
eec1105 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 3, 2019
@Garfield-fr
library exceptions date: improvement
2eb2c61 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 3, 2019
@Garfield-fr
library exceptions date: improvement
93357c1 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 3, 2019
@Garfield-fr
library exceptions date: improvement
a43ea98 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Apr 8, 2019
@Garfield-fr
library exceptions date: improvement
b5c2fc4 
* BETTER Change the layout of the fields in the repeat area
* FIX closes rero#155 rero#223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Apr 8, 2019
Merged
jma pushed a commit that referenced this issue Apr 8, 2019
@Garfield-fr @jma
library exceptions date: improvement
44360e4 
* BETTER Change the layout of the fields in the repeat area
* FIX closes #155 #223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
jma pushed a commit that referenced this issue May 27, 2019
@Garfield-fr @jma
library exceptions date: improvement
eeef882 
* BETTER Change the layout of the fields in the repeat area
* FIX closes #155 #223
* Change the switch by radio buttons on the exception type and status

Signed-off-by: Bertrand Zuchuat <[email protected]>
@NicolasLabat
Copy link
Contributor

It remains a bug : when enter a date exception, activate/deactivate the repeat button has the effect to disable the OK button.

Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Aug 27, 2019
@Garfield-fr
libraries date exceptions: fix bug on repeat button
c507398 
* Closes rero#223

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr Garfield-fr mentioned this issue Aug 27, 2019
Merged
BadrAly pushed a commit to Garfield-fr/rero-ils that referenced this issue Sep 2, 2019
@Garfield-fr
libraries date exceptions: fix bug on repeat button
f37e95d 
* Closes rero#223

Co-Authored-by: Bertrand Zuchuat <[email protected]>
iGormilhit pushed a commit that referenced this issue Sep 2, 2019
@Garfield-fr
libraries date exceptions: fix bug on repeat button
84ac786 
* Closes #223

Co-Authored-by: Bertrand Zuchuat <[email protected]>
jma pushed a commit that referenced this issue Sep 3, 2019
@Garfield-fr @jma
libraries date exceptions: fix bug on repeat button
91d7308 
* Closes #223

Co-Authored-by: Bertrand Zuchuat <[email protected]>
@rerowep rerowep closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iGormilhit @pronguen @NicolasLabat @rerowep