Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holdings are collapsed by default in the public and professional document detailed view #2133

Closed
pronguen opened this issue Jul 8, 2021 · 0 comments · Fixed by rero/rero-ils-ui#671
Closed

Holdings are collapsed by default in the public and professional document detailed view #2133

pronguen opened this issue Jul 8, 2021 · 0 comments · Fixed by rero/rero-ils-ui#671
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years) UX User experience, ergonomy

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 8, 2021 •
edited
Loading

How it works

Currently, holdings are opened by default, displaying all items:
image

Improvement suggestion (see also #2134)

Holdings are collapsed by default, giving a better overview of the holdings:
image

Nice to have: if only one holdings is displayed, it is not collapsed.

Improvement: in the public view, the holdings availability + number of items is displayed in collapsed mode. It should also be the case in the professional interface.

Professional vs. public view
image
@pronguen pronguen added enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years) UX User experience, ergonomy labels Jul 8, 2021
@zannkukai zannkukai self-assigned this Jul 12, 2021
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 13, 2021
@zannkukai
document: upgrade holdings/items display
5b6b638 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.

Co-authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai mentioned this issue Jul 13, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
8c532e0 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.

Co-authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
0beef38 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.
* Closes rero/rero-ils#2172.

Co-authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
bddc129 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.
* Closes rero/rero-ils#2172.

Co-authored-by: Renaud Michotte <[email protected]>
iGormilhit pushed a commit to rero/rero-ils-ui that referenced this issue Jul 20, 2021
@zannkukai
documents: optimize holdings/items display
bd6e0d6 
* Loads/displays more holding by default (10). Collapse holdings panels if
  there are more than 1 holdings to display.
* Loads/displays more items by default (10).
* Fixes linting of `public-search` project.
* Harmonizes public/professional document view.
* Closes rero/rero-ils#2134.
* Closes rero/rero-ils#2133.
* Closes rero/rero-ils#2172.

Co-authored-by: Renaud Michotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface p-Medium Medium priority (to be solved within 1-2 years) UX User experience, ergonomy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

documents: optimize holdings/items display zannkukai/rero-ils-ui
2 participants
@pronguen @zannkukai