Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentMediaCarrier : value to remove and placeholder to add #1924

Closed
ThierryClavel opened this issue May 14, 2021 · 2 comments · Fixed by #2753
Closed

ContentMediaCarrier : value to remove and placeholder to add #1924

ThierryClavel opened this issue May 14, 2021 · 2 comments · Fixed by #2753
Assignees
Labels
bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)

Comments

@ThierryClavel
Copy link

ThierryClavel commented May 14, 2021

In the professional interface, the element Content, media, carrier type is constituted of 3 subelements : contenttype, mediatype and carriertype.
1- the value "Content type" (type de contenu) in yellow, should be removed from list of values.
2- A placeholder "Choose the type of media (choisir le type de media) should be added
image

@iGormilhit iGormilhit added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels May 17, 2021
@zannkukai
Copy link
Contributor

zannkukai commented Jul 19, 2021

@ThierryClavel
1st image: ContentType isn't a place holder, this is the value of the field. See https://github.com/rero/rero-ils/blob/dev/rero_ils/modules/documents/jsonschemas/documents/document_content_media_carrier-v0.0.1.json#L11
In french, it's translated by 'Type de contenu'. In english it's also translated with badly spaced "contentType" string in weblate.
image

2nd image: we can't change the field name when duplicate it. In your example, you duplicated the first "Content, media, carrier type" field (by clicking on double box icon). The field name is duplicated too.

if you're agree, you can close this isssue.

@zannkukai zannkukai self-assigned this Jul 19, 2021
@ThierryClavel
Copy link
Author

please dont close the issue. This field is not clear for users : the field 'content media carrier" is constituted of 3 subfields : content type , media type and carrier type . "Content type" should not be a value of the first field "content media carrier" : a place holder "saisir le type de media"" or a value "media type" should be added instead.

@ThierryClavel ThierryClavel changed the title ContentMediaCarrier : sub-element and placeholder 'contenttype' to rename ContentMediaCarrier : value to remove and placeholder to add Jul 23, 2021
@PascalRepond PascalRepond added bug Breaks something but is not blocking and removed class: correction labels Feb 21, 2022
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 13, 2022
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Jun 13, 2022
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes #2275.
* Closes #2388.
* Closes #2766.
* Closes #2659.
* Closes #2649.
* Closes #2625.
* Closes #2340.
* Closes #1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 14, 2022
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2625.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 14, 2022
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit to Garfield-fr/rero-ils that referenced this issue Jun 14, 2022
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes rero#2275.
* Closes rero#2388.
* Closes rero#2766.
* Closes rero#2659.
* Closes rero#2649.
* Closes rero#2340.
* Closes rero#1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Garfield-fr added a commit that referenced this issue Jun 21, 2022
Fields involved:
supplement, supplementTo, otherEdition, otherPhysicalFormat,
issuedWith, precededBy, succeededBy, relatedTo, hasReproduction,
reproductionOf, work_access_point

* Removes templateOptions on the country jsonschema.
* Fixes typo on the type entry (lower case t).
* Adds the card wrapper on vendors jsonschema.
* Closes #2275.
* Closes #2388.
* Closes #2766.
* Closes #2659.
* Closes #2649.
* Closes #2340.
* Closes #1924.

⚠️  Elasticsearch reindexing.

Co-Authored-by: Bertrand Zuchuat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants