Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Press space for all" only display the 20 first fields in the editor #1908

Closed
pronguen opened this issue May 10, 2021 · 0 comments · Fixed by rero/ng-core#446
Closed

"Press space for all" only display the 20 first fields in the editor #1908

pronguen opened this issue May 10, 2021 · 0 comments · Fixed by rero/ng-core#446
Labels
f: editor Concerns editor based on JSON schema AND custom editor p-Low Low priority

Comments

@pronguen
Copy link
Contributor

How it works

"Press space for all" only display the 20 first fields in the editor. This is especially the case for documents.

How it should works

It should display all field, with an a scroll bar if there are too many.
@pronguen pronguen added f: editor Concerns editor based on JSON schema AND custom editor correction labels May 10, 2021
@iGormilhit iGormilhit added the p-Low Low priority label May 12, 2021
jma added a commit to jma/ng-core that referenced this issue Sep 8, 2021
@jma
editor: speed up the editor
a558fa3 
* Reduces the resource and the time to load the editor.
* Adds a new method to set the list of the hidden fields.
* Removes the bad use of `setTimeout`.
* Adds scroll to suggestion list.
* Closes rero/rero-ils#1747.
* Closes rero/rero-ils#1908.
* Fixes autocomplete external link UI.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/ng-core that referenced this issue Sep 8, 2021
@jma
editor: speed up the editor
edac58f 
* Reduces the resource and the time to load the editor.
* Adds a new method to set the list of the hidden fields.
* Removes the bad use of `setTimeout`.
* Adds scroll to suggestion list.
* Closes rero/rero-ils#1747.
* Closes rero/rero-ils#1908.
* Fixes autocomplete external link UI.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma mentioned this issue Sep 8, 2021
Merged
7 tasks
jma added a commit to rero/ng-core that referenced this issue Sep 9, 2021
@jma
editor: speed up the editor
19fa440 
* Reduces the resource and the time to load the editor.
* Adds a new method to set the list of the hidden fields.
* Removes the bad use of `setTimeout`.
* Adds scroll to suggestion list.
* Closes rero/rero-ils#1747.
* Closes rero/rero-ils#1908.
* Fixes autocomplete external link UI.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
f: editor Concerns editor based on JSON schema AND custom editor p-Low Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: speed up the editor jma/ng-core
2 participants
@iGormilhit @pronguen