Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a request on an item should not update the operation logs #1779

Closed
pronguen opened this issue Mar 17, 2021 · 0 comments · Fixed by #2395
Closed

Add a request on an item should not update the operation logs #1779

pronguen opened this issue Mar 17, 2021 · 0 comments · Fixed by #2395
Assignees
@zannkukai
Labels
f: activity-logs Everything around logging user or system activities p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v1.5.0

Comments

@pronguen
Copy link
Contributor

pronguen commented Mar 17, 2021 •
edited
Loading

How it works

Currently, adding a request to an item updates the operation logs of the item. This is also the case of other circulation operations (checkouts, ...) because they update the item status in the DB.

How it should works

The item operation logs should log only the update of the item intrinsic fields (barcode, location, etc.), and should not be affected by the circulation operations. A modification of the item status should not be logged.

Related to #1725
@pronguen pronguen added triage bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) labels Mar 17, 2021
@pronguen pronguen mentioned this issue Mar 17, 2021
Closed
@iGormilhit iGormilhit removed the triage label Apr 26, 2021
@iGormilhit iGormilhit added this to the v1.3.0 milestone Apr 26, 2021
@iGormilhit iGormilhit added logs and removed bug Breaks something but is not blocking labels Apr 26, 2021
@iGormilhit iGormilhit modified the milestones: v1.3.0, v1.4.0 Jun 21, 2021
@iGormilhit iGormilhit added f: activity-logs Everything around logging user or system activities and removed logs labels Jun 29, 2021
@iGormilhit iGormilhit modified the milestones: v1.4.0, v1.5.0 Jul 5, 2021
@zannkukai zannkukai self-assigned this Sep 20, 2021
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 21, 2021
@zannkukai
operation log: untrack some changes.
b609f8a 
* Some changes should not be track by an operation log. If a circulation
  operation is done, this will change the related item status. This
  change should not be generate an operation log.
* Use the Invenio extensions to manage operation logs creation.
* Closes rero#1779.

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai mentioned this issue Sep 21, 2021
Merged
7 tasks
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 21, 2021
@zannkukai
operation log: untrack some changes.
89a1aa4 
* Some changes should not be track by an operation log. If a circulation
  operation is done, this will change the related item status. This
  change should not be generate an operation log.
* Use the Invenio extensions to manage operation logs creation.
* Closes rero#1779.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 21, 2021
@zannkukai
operation log: untrack some changes.
4c5a217 
* Some changes should not be track by an operation log. If a circulation
  operation is done, this will change the related item status. This
  change should not be generate an operation log.
* Use the Invenio extensions to manage operation logs creation.
* Closes rero#1779.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 21, 2021
@zannkukai
operation log: untrack some changes.
e82ce2a 
* Some changes should not be track by an operation log. If a circulation
  operation is done, this will change the related item status. This
  change should not be generate an operation log.
* Use the Invenio extensions to manage operation logs creation.
* Closes rero#1779.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 23, 2021
@zannkukai
operation logs: untrack some changes
e6c29ea 
* Some changes should not be tracked by an operation log (!= an
  operation log for loan history). If a circulation operation is done,
  this will change the related item status, but should not generate an
  operation log as it will be shown in the operation history on resource
  such as item or document. Furthermore, the circulation operation are
  already tracked.
* Use the Invenio extensions to manage operation log creation.
* Closes rero#1779.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to zannkukai/rero-ils that referenced this issue Sep 28, 2021
@zannkukai
operation logs: untrack some changes
8380f0e 
* Some changes should not be tracked by an operation log (!= an
  operation log for loan history). If a circulation operation is done,
  this will change the related item status, but should not generate an
  operation log as it will be shown in the operation history on resource
  such as item or document. Furthermore, the circulation operation are
  already tracked.
* Use the Invenio extensions to manage operation log creation.
* Closes rero#1779.

Co-Authored-by: Renaud Michotte <[email protected]>
@jma jma closed this as completed in 923efff Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
f: activity-logs Everything around logging user or system activities p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

operation logs: untrack some changes. zannkukai/rero-ils
4 participants
@iGormilhit @pronguen @zannkukai @BadrAly