Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a second filter to the organisation facet filter has no effect #1684

Closed
jma opened this issue Feb 8, 2021 · 1 comment · Fixed by rero/ng-core#359
Closed

Add a second filter to the organisation facet filter has no effect #1684

jma opened this issue Feb 8, 2021 · 1 comment · Fixed by rero/ng-core#359
Labels
bug Breaks something but is not blocking f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: search p-High High priority (to be solved in the 2-3 next months)
Milestone
v1.1.0

Comments

@jma
Copy link
Contributor

jma commented Feb 8, 2021 •
edited by iGormilhit
Loading

Describe the bug

When an organisation filter is selected the number of results are filtered but when a second is selected it has no effect. This appears on the public and professional view. Other facets can be impacted.

To Reproduce

  1. Go to the search result on the public global view.
  2. Click on an organisation filter.
  3. See the number of results changes.
  4. Click an other organisation filter.
  5. Errror: the number of results does not change.

Expected behavior

Multiple facet filters should works.

Context
@jma jma added triage bug Breaks something but is not blocking labels Feb 8, 2021
@iGormilhit iGormilhit added this to the v1.2.0 milestone Feb 8, 2021
@iGormilhit iGormilhit added f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: search p-High High priority (to be solved in the 2-3 next months) and removed triage labels Feb 9, 2021
@rerowep
Copy link
Contributor

rerowep commented Feb 9, 2021

Maybe related to #962

@sebdeleze sebdeleze mentioned this issue Mar 5, 2021
Merged
sebdeleze pushed a commit to rero/ng-core that referenced this issue Mar 12, 2021
search: fix second filter selection
9d57bb9 
* Fixes second filter selection, which did not launch the search. This was caused by the search parameters subject which sends the original object instead of a copied one.
* Closes rero/rero-ils#1684.

Co-Authored-by: Sébastien Délèze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: professional ui Professional interface f: public ui Public interface, as opposed to the professional interface f: search p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

search: fix second filter selection
3 participants
@jma @iGormilhit @rerowep