Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve navigation inconsistencies in the professional interface #1645

Closed
JoelleDosimont opened this issue Jan 27, 2021 · 6 comments · Fixed by rero/rero-ils-ui#1073
Closed
Labels
enhancement Improvement of an existing feature f: professional ui Professional interface stale Stale or no longer relevant UX User experience, ergonomy

Comments

@JoelleDosimont
Copy link
Contributor

JoelleDosimont commented Jan 27, 2021

How it works

Some inconsistencies exist about the navigation in RERO ILS (professional view).

Improvement suggestion

  • Document view, serial holdings: replace the file-text-o button (already in use for the quick receive on the holdings view) by an eye button (which is going to mean "display").

Already solved

  • Item view: add an Edit and Delete button (for all type of items).
  • Holdings view: remove the eye button to access an issue. The access is done via a link on the field enumerationAndChronology, so that it is placed on the left as in the document view.
@JoelleDosimont JoelleDosimont added enhancement Improvement of an existing feature triage labels Jan 27, 2021
@iGormilhit iGormilhit changed the title Item : add the possibility to edit the item in the detail view Add the possibility to edit the item in the detailed view Jan 28, 2021
@iGormilhit iGormilhit added p-Low Low priority f: professional ui Professional interface UX User experience, ergonomy and removed triage labels Jan 28, 2021
@pronguen
Copy link
Contributor

pronguen commented Feb 1, 2021

I think that a certain harmonisation is needed globally. List of points:

  • holdings/item detailed view: link to the host document should be displayed in the same way
  • links to items and holdings from document/hodlings detailed view. Currently, there are accessible through buttons (with 2 different icons: eye, document) and through links on the barcode. The buttons have the problem that they cannot open the link in a new tab.

image

@pronguen pronguen changed the title Add the possibility to edit the item in the detailed view Solve navigation inconsistencies in the professional interface Feb 3, 2021
@iGormilhit iGormilhit added this to the v1.2.0 milestone Feb 8, 2021
@jma jma modified the milestones: v1.1.0, v1.2.0 Mar 17, 2021
@zannkukai
Copy link
Contributor

@pronguen The buttons linked to the holdings are only present for serial holding. If we allow to edit a normal holding, there are no logic in the backend to cascade holding changes to related items (location, circulation category, document).
Additionally there are currently no "delete" button because it will always disable with cause than item are linked to it. The logic in te backend is : when last item related to an holding is deleted, then delete the holding.

The "document" icon isn't to link to the document view, but for "Bulettinage" of serial holding. (maybe a better icon ? suggestion ?)

@pronguen no problem to remove the eye button --> link on enumerationAndChronology.

If you would change these behaviors, it will affect a lot of backend code/logic.
@BadrAly What's your feeling about these problems ?

@pronguen
Copy link
Contributor

@zannkukai

@pronguen The buttons linked to the holdings are only present for serial holding.

Yes, that's ok. Don't add anything to the non serial holdings. This is not specified in this issue.

The "document" icon isn't to link to the document view, but for "Bulettinage" of serial holding. (maybe a better icon ? suggestion ?)

No. If you click on it, it does not execute a bulletinage, it just opens the holdings detailed view. From that view, we can do the actual bulletinage. This is the inconsistency. For this reason, we wrote (main text of this issue):
Document view, serial holdings: replace the file-text-o button (already in use for the quick receive on the holdings view) by an eye button (which is going to mean "display")

@pronguen pronguen removed this from the v1.2.0 milestone Apr 14, 2021
@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Aug 21, 2022
@pronguen pronguen reopened this Aug 22, 2022
@pronguen pronguen removed the stale Stale or no longer relevant label Aug 22, 2022
@github-actions
Copy link

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Feb 19, 2023
@github-project-automation github-project-automation bot moved this to Sprint backlog in RERO ILS issues Mar 30, 2023
@PascalRepond PascalRepond moved this from Sprint backlog to New/needs refine in RERO ILS issues Mar 30, 2023
@PascalRepond PascalRepond added needs info and removed p-Low Low priority stale Stale or no longer relevant needs info labels Mar 30, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

This issue is stale because it has been open 6 months with no activity.

@github-actions github-actions bot added the stale Stale or no longer relevant label Oct 4, 2023
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this issue Nov 9, 2023
* Changes some icons to more adapted versions.
* Closes rero/rero-ils#1645.

Co-Authored-by: Pascal Repond <[email protected]>
PascalRepond added a commit to rero/rero-ils-ui that referenced this issue Nov 15, 2023
* Changes some icons to more adapted versions.
* Closes rero/rero-ils#1645.

Co-Authored-by: Pascal Repond <[email protected]>
@github-project-automation github-project-automation bot moved this from Inbox to Done in RERO ILS issues Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature f: professional ui Professional interface stale Stale or no longer relevant UX User experience, ergonomy
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants