Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document: unable to edit a document (duplicated from an ebook) #1542

Closed
benerken opened this issue Dec 3, 2020 · 0 comments · Fixed by rero/rero-ils-ui#460
Closed

document: unable to edit a document (duplicated from an ebook) #1542

benerken opened this issue Dec 3, 2020 · 0 comments · Fixed by rero/rero-ils-ui#460
Assignees
@zannkukai
Labels
enhancement Improvement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)

Comments

@benerken
Copy link
Contributor

benerken commented Dec 3, 2020 •
edited
Loading

If a librarian wants to duplicate an existing "ebook" (= harvested from external source) in order to create a new document (ex: paper copy), it works but the new document has still the attribute "harvested=true"
It means the librarian can't edit it because, for rero-ils, it's still an external record.

To Reproduce

  1. Login as Jean
  2. Find an ebook and duplicate it as a "book". Save It. It works.
  3. Try to edit your new document (book). You can't

Expected behavior

A librarian should be able to edit a document duplicated from an external record
Please remove the attribute "harvested=true" from the json document

  • server: ilsdev.test.rero.ch
  • version: v0.14.1
@benerken benerken added triage bug Breaks something but is not blocking labels Dec 3, 2020
@iGormilhit iGormilhit added f: data About data model, importation, transformation, exportation of data, specific for bibliographic data enhancement Improvement of an existing feature f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years) and removed triage bug Breaks something but is not blocking labels Dec 3, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Dec 8, 2020
@zannkukai
document: fix duplicate harvested document
7ea3f08 
When an harvested document is duplicate, then the `harvested` flag must
be removed.

Closes rero/rero-ils#1542

Co-Authored-by: Renaud Michotte <[email protected]>
@zannkukai zannkukai mentioned this issue Dec 8, 2020
Merged
7 tasks
@zannkukai zannkukai self-assigned this Dec 8, 2020
zannkukai added a commit to zannkukai/rero-ils-ui that referenced this issue Dec 9, 2020
@zannkukai
document: allow to duplicate harvested document
9f9da32 
When an harvested document is duplicated, the `harvested` flag must
be removed.

Closes rero/rero-ils#1542.

Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai added a commit to rero/rero-ils-ui that referenced this issue Dec 10, 2020
@zannkukai
document: allow to duplicate harvested document
2cb09f9 
When an harvested document is duplicated, the `harvested` flag must
be removed.

Closes rero/rero-ils#1542.

Co-Authored-by: Renaud Michotte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zannkukai zannkukai

Labels
enhancement Improvement of an existing feature f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: editor Concerns editor based on JSON schema AND custom editor p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document: fix duplicate harvested document zannkukai/rero-ils-ui
3 participants
@iGormilhit @zannkukai @benerken