Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patron without email is not able to change his personal informations #1459

Closed
jma opened this issue Nov 18, 2020 · 0 comments
Closed

Patron without email is not able to change his personal informations #1459

jma opened this issue Nov 18, 2020 · 0 comments
Assignees
@jma
Labels
bug Breaks something but is not blocking f: user management p-Medium Medium priority (to be solved within 1-2 years)
Milestone
v0.14.1

Comments

@jma
Copy link
Contributor

jma commented Nov 18, 2020

Describe the bug
A patron without an email cannot change his personal information such as address, city, etc.

To Reproduce
Steps to reproduce the behavior:

  1. Log in with an patron without email account.
  2. Go to the RERO ID personal information form.
  3. Try to change the address.
  4. The form cannot be submitted as the email is required.
@jma jma added triage bug Breaks something but is not blocking labels Nov 18, 2020
@jma jma added this to the v0.14.1 milestone Nov 18, 2020
@iGormilhit iGormilhit added p-High High priority (to be solved in the 2-3 next months) f: user management labels Nov 19, 2020
@iGormilhit iGormilhit added p-Medium Medium priority (to be solved within 1-2 years) and removed p-High High priority (to be solved in the 2-3 next months) triage labels Nov 19, 2020
jma added a commit to jma/rero-ils that referenced this issue Nov 19, 2020
@jma
patrons: fix patron creation and modification
377dd44 
* Fixes a patron creation with an existing user account, closes: rero#1454.
* Fixes user profile information modification for a user without email,
  closes rero#1459.
* Fixes a required email for a patron creation if the communication
  channel is email, closes rero#1455.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma mentioned this issue Nov 19, 2020
Merged
6 tasks
jma added a commit to jma/rero-ils that referenced this issue Nov 19, 2020
@jma
patrons: fix patron creation and modification
7b091c9 
* Fixes a patron creation with an existing user account, closes: rero#1454.
* Fixes user profile information modification for a user without email,
  closes rero#1459.
* Fixes a required email for a patron creation if the communication
  channel is email, closes rero#1455.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/invenio-userprofiles that referenced this issue Nov 19, 2020
@jma
profile: make the email optional
78bc1e5 
* Fixes user profile information modification for a user without email,
  closes rero/rero-ils#1459.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma mentioned this issue Nov 19, 2020
Merged
@jma jma closed this as completed Nov 19, 2020
rerowep pushed a commit to rero/invenio-userprofiles that referenced this issue Dec 23, 2020
@jma @rerowep
profile: make the email optional
de5957c 
* Fixes user profile information modification for a user without email,
  closes rero/rero-ils#1459.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
rerowep pushed a commit to rero/invenio-userprofiles that referenced this issue Dec 23, 2020
@jma @rerowep
profile: make the email optional
23d3824 
* Fixes user profile information modification for a user without email,
  closes rero/rero-ils#1459.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
jma added a commit to jma/invenio-userprofiles that referenced this issue Feb 11, 2021
@jma
profile: make the email optional
502c562 
* Fixes user profile information modification for a user without email,
  closes rero/rero-ils#1459.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jma jma

Labels
bug Breaks something but is not blocking f: user management p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
v0.14.1
Development

No branches or pull requests
2 participants
@jma @iGormilhit