Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

item: add request on item by librarian #147

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

Garfield-fr
Copy link
Contributor

@Garfield-fr Garfield-fr commented Feb 7, 2020

Co-Authored-by: Bertrand Zuchuat [email protected]

Why are you opening this PR?

  • to add request functionality on item by the librarian

How to test?

  • Dependency: requests: place a request for a patron by a librarian rero-ils#835
  • Test "new request" on item (document detail view)
  • Several cases where the request can't be performed can be tested:
    • invalid patron barcode
    • an item can't be requested due to the circulation policies (for ex. with a specific item_type)
    • the item has been already requested by the same patron

Screenshots

image

Code review check list

  • Commit message template compliance.
  • Commit message without typos.
  • File names.
  • Functions names.
  • Functions docstrings.
  • Unnecessary commited files?
  • Extracted translations?

@Garfield-fr Garfield-fr added the WIP label Feb 7, 2020
@Garfield-fr Garfield-fr force-pushed the zub-item-patron-request branch 7 times, most recently from 5c385b1 to 931dae5 Compare February 14, 2020 11:12
@Garfield-fr Garfield-fr force-pushed the zub-item-patron-request branch 3 times, most recently from 4fd1c9f to 015ed01 Compare February 18, 2020 14:23
@jma jma force-pushed the zub-item-patron-request branch from 015ed01 to 2124a55 Compare March 5, 2020 10:20
@jma jma added PO Validation and removed WIP labels Mar 5, 2020
@jma jma force-pushed the zub-item-patron-request branch from 2124a55 to 83928a9 Compare March 5, 2020 12:32
@jma jma requested a review from a team March 5, 2020 16:17
@jma jma merged commit 4f30ead into rero:dev Mar 9, 2020
@Garfield-fr Garfield-fr deleted the zub-item-patron-request branch September 7, 2020 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants