-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert 397 and add Deprecation warning instead #485
Conversation
9f66605
to
8ba5b9a
Compare
8ba5b9a
to
811f470
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase from 1.3.1 tag ?
That way we're not introducing other breaking changes already in master.
@JonathanHuot we good now? |
For hotfix, I think we should merge into master only after the release of v1.3.2. So basically, I will suggest to raise PR to merge your changes into the Once your changes merged and reviewed, we can push tag Once released and happy, we can merge |
Closed as no time to fix backward the version to maintain version semantic. |
Semantic version mistake was made when releasing 1.3.1, the Linkedin compliance fix which was removed from the code base, api breaking change, did not trigger a main version release increment. e.g. 1.4 instead of 1.3.1.
This PR reverts the Linkedin compliance hook removal, and instead adds a deprecation warning. Can remove next major version release. Return Linkedin example file to original state as well as bringing back unit tests.
Updates HISTORY and AUTHOR file.