Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 397 and add Deprecation warning instead #485

Closed
wants to merge 5 commits into from
Closed

Conversation

jtroussard
Copy link
Contributor

@jtroussard jtroussard commented Feb 21, 2022

Semantic version mistake was made when releasing 1.3.1, the Linkedin compliance fix which was removed from the code base, api breaking change, did not trigger a main version release increment. e.g. 1.4 instead of 1.3.1.

This PR reverts the Linkedin compliance hook removal, and instead adds a deprecation warning. Can remove next major version release. Return Linkedin example file to original state as well as bringing back unit tests.

Updates HISTORY and AUTHOR file.

…oval"

This reverts commit d75279c, reversing
changes made to 29ba9af.
@coveralls
Copy link

coveralls commented Feb 22, 2022

Coverage Status

Coverage increased (+0.3%) to 90.637% when pulling 16a3473 on revert-397 into b3decdb on master.

@JonathanHuot JonathanHuot added this to the 1.3.2 milestone Feb 23, 2022
Copy link
Contributor

@JonathanHuot JonathanHuot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase from 1.3.1 tag ?
That way we're not introducing other breaking changes already in master.

@jtroussard
Copy link
Contributor Author

@JonathanHuot we good now?

@JonathanHuot
Copy link
Contributor

JonathanHuot commented Mar 10, 2022

For hotfix, I think we should merge into master only after the release of v1.3.2.

So basically, I will suggest to raise PR to merge your changes into the release-1.3.2 branch (just created now based on v1.3.1 tag).

Once your changes merged and reviewed, we can push tag v1.3.2 and that will trigger the release to pypi.

Once released and happy, we can merge release-1.3.2 into master to target 1.4.x.

@JonathanHuot
Copy link
Contributor

Closed as no time to fix backward the version to maintain version semantic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants