fix map() call on undefined; fix unrelate() usage #5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I encountered and fixed this same issue today without noticing this PR and I did the exact same thing. +1 for me |
NGPixel
approved these changes
Oct 25, 2022
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in v2.5.288 doesn't seem to be tested well. We use Keycloak via OIDC (because we need a group mapping which is absent in Keycloak provider) so I fixed it right in prod (yeah it's sort of things we always love). Sending a PR, hope the fix works for others.
await user.$relatedQuery('groups').select('groups.id')already returns a groups array, not an object withgroupsproperty.