feat: allow self-signed ssl #5446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnplkndll
force-pushed
the
feat-pg-allow-selfsigned
branch
from
6d56686
to
39f5e37
Compare
sorvis
reviewed
Jul 6, 2022
dev/helm/values.yaml
Outdated
| @@ -104,7 +114,9 @@ sideload: | |||
|
|
|||
| ## This will override the postgresql chart values | |||
| # externalPostgresql: | |||
| # databaseURL: postgresql://postgres:postgres@postgres:5432/wiki?sslmode=require | |||
| # databaseURL: postgresql://postgres:postgres@postgres:5432/wiki?ssl=true | |||
| # # For sign signed, like DigitalOcean | |||
feat: startup probe fix: nil externalPostgresql
dnplkndll
force-pushed
the
feat-pg-allow-selfsigned
branch
from
39f5e37
to
2540f40
Compare
NGPixel
approved these changes
Jul 6, 2022
|
@NGPixel a secret deployment on the apparent external support using postgresqlHost (wip) Also I think if your default image is a floating latest you would want an Always pull or the image will not change once on the node. Not planning to PR unless you see a need as our case is covered now with the _URL this was effort in the postgresql.ca approach |
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not seem to get around the self signed easily. this works perhaps 2 would be better but I could not get it to work even when passed as a string without the head/footer
https://gist.github.com/zmts/f3306945e90914c4dedda5e0eaf1a279#solution-2
Added
feat: startup probe
at any rate this will work with DO connection string with the change of sslmode=require to ssl=true. could handle but likely a note is sufficient or maybe os obvious.