saml auth: authnContext must be a list now
#5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes
this.options.authnContext.forEach is not a function
when trying to login via SAML on wiki-js 2.5.281.
Reason for that is that `authnContext` must be a list now which is
apparently a breaking change that was missed while upgrading
passport-saml[1].
Resolves requarks#5289
[1] node-saml/passport-saml#615
13 tasks
NGPixel
added a commit
that referenced
this pull request
May 20, 2022
* saml auth: `authnContext` must be a list now
This fixes
this.options.authnContext.forEach is not a function
when trying to login via SAML on wiki-js 2.5.281.
Reason for that is that `authnContext` must be a list now which is
apparently a breaking change that was missed while upgrading
passport-saml[1].
Resolves #5289
[1] node-saml/passport-saml#615
* fix(auth): split authnContext for SAML authenticaiton module
Co-authored-by: Nicolas Giard <[email protected]>
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
) * saml auth: `authnContext` must be a list now This fixes this.options.authnContext.forEach is not a function when trying to login via SAML on wiki-js 2.5.281. Reason for that is that `authnContext` must be a list now which is apparently a breaking change that was missed while upgrading passport-saml[1]. Resolves requarks#5289 [1] node-saml/passport-saml#615 * fix(auth): split authnContext for SAML authenticaiton module Co-authored-by: Nicolas Giard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
when trying to login via SAML on wiki-js 2.5.281.
Reason for that is that
authnContextmust be a list now which isapparently a breaking change that was missed while upgrading
passport-saml[1].
Resolves #5289
[1] node-saml/passport-saml#615
cc @NGPixel