Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add support for spec.ingressClassName to Ingress template #5202

Merged
merged 2 commits into from
May 9, 2022

Conversation

martinlindner
Copy link
Contributor

Since PR #4437 the helm chart's ingress template generates a kubernetes.io/ingress.class annotation based on .Values.ingress.className for K8s <1.18:

{{- if and .Values.ingress.className (not (semverCompare ">=1.18-0" .Capabilities.KubeVersion.GitVersion)) }}
{{- if not (hasKey .Values.ingress.annotations "kubernetes.io/ingress.class") }}
{{- $_ := set .Values.ingress.annotations "kubernetes.io/ingress.class" .Values.ingress.className}}
{{- end }}
{{- end }}

On >=1.18, spec.ingressClassName should be supported instead.

@NGPixel
Copy link
Member

NGPixel commented Apr 29, 2022

Please restore the spaces that were stripped at the end of lines in README.md, these are needed to force a line break in markdown.

@martinlindner
Copy link
Contributor Author

Oops, sorry, I didn't notice vscode's overly aggressive whitespace trimming.

Should be fixed now, please have another look.

@NGPixel NGPixel removed the needs-work label May 9, 2022
@NGPixel NGPixel merged commit a06201a into requarks:main May 9, 2022
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants