#5164 Administrator general setting is not saving with empty value. #5165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e old value is updated on Administrator General setting. fix the issue
NGPixel
approved these changes
Apr 9, 2022
|
Thanks! Although I'm not sure why you would save any of these settings with an empty value... |
|
I don't want to display copyrights string in the footer, so as per implementation if we keep footer copyright and content license as empty. the string will not be displayed. |
|
While it can technically be removed, an option to do so will not be added. This is a free, open source software... The least you can do is to have a mention in the footer to support it... |
biocrossroads
pushed a commit
to biocrossroads/biocrossroads-wiki
that referenced
this pull request
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Change the if condition, so instead of checking for the property directly, Checking using "hasOwnProperty" method.
Please associate this PR with issue #5164