Updated values file to imagePullPolicy to match what is in templates/deployment.yaml #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the line in code we need to match: https://github.com/wjkw1/wiki/blob/dev/dev/helm/templates/deployment.yaml#L29
NGPixel
approved these changes
Oct 9, 2021
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
…ent.yaml (requarks#4546) ***NO_CI***
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix will allow people to correctly set the image pull policy from the values file when running wiki.js in kubernetes.
Currently setting the value does not get picked up, it always uses the default of IfNotPresent. Users may want to set Always OR Never but would need to change the helm chart.
This is the deployment.yaml line in code we are updating to match:
https://github.com/wjkw1/wiki/blob/dev/dev/helm/templates/deployment.yaml#L29