Hide footnotes keyline when preceded by header #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream
Hide key-line created by `markdown-it-footnote` template when footnotes are directly preceded by header. Examples: ```md # References [^1]: Shows no key-line because References header has one already # New Page Text goes here and whatever else [^1]: these footnotes have no preceding header and will show a key-line ```
NGPixel
approved these changes
Oct 2, 2021
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
Hide key-line created by `markdown-it-footnote` template when footnotes are directly preceded by header. Examples: ```md # References [^1]: Shows no key-line because References header has one already # New Page Text goes here and whatever else [^1]: these footnotes have no preceding header and will show a key-line ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're provided base styles to work "out of the box", we should consider edge cases such as this where footnotes always show their own keyline, even when preceded by a Header (which is styled with a keyline underneath)
This PR hides key-lines created by
markdown-it-footnotetemplate when footnotes are directly preceded by header, but leaves them in place when the footnotes follow regular Phrasing content.Examples: