TOC Links and Custom Header ID Fix #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge upstream
Fix the issue described in discussion requarks#3502 regarding header links and TOC failing to properly generate when header ID is custom defined.
NGPixel
approved these changes
Oct 2, 2021
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
Fix the issue described in discussion requarks#3502 regarding header links and TOC failing to properly generate when header ID is custom defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR fixes the issue where TOC Links fail to work for headers that have been given a custom ID, or when defined in the HTML body as discussed in #3502
Such as in the scenario below, where Wiki.js will fail to properly generate the page TOC for Header 1