Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack Auth fix: replace passport-slack implementation #4369

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Slack Auth fix: replace passport-slack implementation #4369

merged 1 commit into from
Sep 1, 2021

Conversation

ehossack
Copy link
Contributor

@ehossack ehossack commented Sep 1, 2021

This commit replaces the observably defunct @aoberoi/passport-slack
implementation with that of nmaves's passport-slack-oauth2

I have (manually) tested this on a local installation to verify it does correctly work with a slack + wiki.js installation.

This commit replaces the observably defunct @aoberoi/passport-slack
implementation with that of nmaves's passport-slack-oauth2
@ehossack
Copy link
Contributor Author

ehossack commented Sep 1, 2021

This addresses #3335

@ehossack
Copy link
Contributor Author

ehossack commented Sep 1, 2021

Looking at the releases, it looks like 3.0 is the next targeted release. Given that the 2.X stream is currently broken for slack auth, and assuming we're able to create a fix within this PR, is it viable to consider cutting a 2.X release before the 3.0 beta?
(selfish question of course, but I'm not sure the viability of running a patched version myself - given the giant red "THIS IS A DEV VERSION" warning that happens with node serve 😅)

@nasiralamreeki
Copy link

release

The 3.0 repo doesn't even look very active so my guess is a beta isn't coming anytime soon. Would be nice to see more updates to 2.x until there is a beta as 2.x still has bugs.

@omenos
Copy link

omenos commented Sep 1, 2021

Thanks for doing this @ehossack! Hopefully this gets merged and a new 2.x cut, would be really helpful for a project I'm working on.

You might be able to generate the non-dev banner build by following the steps in the dev/build/Dockerfile file.

Edit: Need to change the dev and version vars in package.json.

@NGPixel NGPixel merged commit 9864be8 into requarks:dev Sep 1, 2021
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
This commit replaces the observably defunct @aoberoi/passport-slack
implementation with that of nmaves's passport-slack-oauth2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants