Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: graceful shutdown #3821

Merged
merged 3 commits into from
Apr 12, 2021
Merged

fix: graceful shutdown #3821

merged 3 commits into from
Apr 12, 2021

Conversation

lkho
Copy link
Contributor

@lkho lkho commented Apr 12, 2021

There is a graceful shutdown procedure written in the kernel, but not registered with the process exit handler.

This change adds:

  • a SIGINT handler,
  • a PM2 specific message handler on windows platform,
  • and properly shutdown the scheduler and wait for running jobs to complete before exiting.

@auto-assign auto-assign bot requested a review from NGPixel April 12, 2021 07:57
@NGPixel NGPixel merged commit a103127 into requarks:dev Apr 12, 2021
@NGPixel
Copy link
Member

NGPixel commented Apr 12, 2021

Thanks for all 3 great PRs!

@pms1969 pms1969 mentioned this pull request Sep 24, 2021
Merged
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
@lkho
fix: graceful shutdown (requarks#3821)
2046bde 
* fix: missing graceful shutdown handler

* fix: asar - use async fs operation

* fix: scheduler - graceful shutdown and wait for running jobs to complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGPixel NGPixel Awaiting requested review from NGPixel

Assignees

@NGPixel NGPixel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkho @NGPixel