Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sidebar base64 decode #1975

Merged
merged 1 commit into from
Jun 1, 2020
Merged

fix: sidebar base64 decode #1975

merged 1 commit into from
Jun 1, 2020

Conversation

takumi9942
Copy link
Contributor

This fixes garbled sidebar text. (fix #1971)
atob() function has a Unicode Problem.

The btoa() function takes a JavaScript string as a parameter. In JavaScript strings are represented using the UTF-16 character encoding: in this encoding, strings are represented as a sequence of 16-bit (2 byte) units. Every ASCII character fits into the first byte of one of these units, but many other characters don't. -- from MDN web docs

ScreenShot
compare

@auto-assign auto-assign bot requested a review from NGPixel June 1, 2020 10:11
@NGPixel NGPixel merged commit bcd32d4 into requarks:master Jun 1, 2020
jionggyu pushed a commit to jionggyu/wiki-2.5.302-patch that referenced this pull request Jul 9, 2024
@takumi9942
fix: sidebar base64 decode (requarks#1975)
4c0c71c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGPixel NGPixel NGPixel approved these changes

Assignees

@NGPixel NGPixel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update wiki version to 2.4.75, Errors with garbled codes
2 participants
@takumi9942 @NGPixel