Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for VSCode remote development #1533

Merged
merged 2 commits into from
Feb 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// How to get remote container development working with VSCode:
// 1. Install "Remote Development" extension pack (ms-vscode-remote.vscode-remote-extensionpack)
// 2. Select "Remote Containers - Reopen in container"

{
"name": "Wiki.js",
"dockerComposeFile": [
"../dev/containers/docker-compose.yml"
],
"forwardPorts": [3000, 3001],
"service": "wiki",
"workspaceFolder": "/wiki",
"settings": {
"terminal.integrated.shell.linux": "/bin/bash"
},
"extensions": [
"EditorConfig.editorconfig",
"dbaeumer.vscode-eslint",
"christian-kohler.path-intellisense",
"mrmlnc.vscode-puglint",
"octref.vetur",
"dzannotti.vscode-babel-coloring",
"wayou.vscode-todo-highlight",
"visualstudioexptteam.vscodeintellicode",
"lukas-tr.materialdesignicons-intellisense",
"codezombiech.gitignore",
"kumar-harsh.graphql-for-vscode",
"mrmlnc.vscode-duplicate",
"oderwat.indent-rainbow",
"christian-kohler.npm-intellisense"
],
"postCreateCommand": ["yarn", "install"]
}
5 changes: 1 addition & 4 deletions dev/docker-postgres/Dockerfile → dev/containers/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,17 +1,14 @@
# -- DEV DOCKERFILE --
# -- DO NOT USE IN PRODUCTION! --

FROM node:10-alpine
FROM node:12-alpine
LABEL maintainer "requarks.io"

RUN apk update && \
apk add bash curl git python make g++ nano openssh gnupg --no-cache && \
mkdir -p /wiki

WORKDIR /wiki
COPY package.json .
RUN yarn --silent
COPY ./dev/docker-postgres/init.sh ./init.sh

ENV dockerdev 1
ENV DEVDB postgres
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -27,40 +27,38 @@ services:
ports:
- "3001:8080"

solr:
image: solr:7-alpine
logging:
driver: "none"
networks:
- wikinet
ports:
- "8983:8983"
volumes:
- solr-data:/opt/solr/server/solr/mycores
entrypoint:
- docker-entrypoint.sh
- solr-precreate
- wiki
# solr:
# image: solr:7-alpine
# logging:
# driver: "none"
# networks:
# - wikinet
# ports:
# - "8983:8983"
# volumes:
# - solr-data:/opt/solr/server/solr/mycores
# entrypoint:
# - docker-entrypoint.sh
# - solr-precreate
# - wiki

wiki:
build:
context: .
dockerfile: dev/docker-postgres/Dockerfile
context: ../..
dockerfile: dev/containers/Dockerfile
depends_on:
- db
- solr
networks:
- wikinet
ports:
- "3000:3000"
volumes:
- .:/wiki
- ../..:/wiki
- /wiki/node_modules
command: ["sh", "./dev/docker-postgres/init.sh"]

networks:
wikinet:

volumes:
db-data:
solr-data:
# solr-data:
178 changes: 0 additions & 178 deletions dev/docker-common/wait.sh

This file was deleted.

21 changes: 0 additions & 21 deletions dev/docker-mariadb/Dockerfile

This file was deleted.

10 changes: 0 additions & 10 deletions dev/docker-mariadb/config.yml

This file was deleted.

50 changes: 0 additions & 50 deletions dev/docker-mariadb/docker-compose.yml

This file was deleted.

6 changes: 0 additions & 6 deletions dev/docker-mariadb/init.sh

This file was deleted.

Loading