Error when viewing source of previous page revision

[Chrisc-c-c]

Describe the bug
When trying to view the source of a previous version of a page, the source fails to load and I instead receive the following error page:

Oops, something went wrong...
/wiki/server/views/source.pug:7 5| block body 6| #root > 7| page-source( 8| :page-id=page.id 9| locale=page.localeCode 10| path=page.path The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined

To Reproduce
Steps to reproduce the behavior:

1. Open a wiki page.
2. Click on History.
3. Click the three dots next to a page revision.
4. Click "View Source".

Expected behavior
Revision source should be shown

Host Info (please complete the following information):

• OS: Docker
• Wiki.js version: 2.5.170
• Database engine: Postgres 11.7

[mihailim]

Confirming, this happens with the non-Docker version as well.

• OS: Ubuntu 18.04
• Wiki.js version: 2.5.170
• Database engine: Postgres 13.1

[slysiou]

I get the same issue:
/wiki/server/views/source.pug:7 5| block body 6| #root > 7| page-source( 8| :page-id=page.id 9| locale=page.localeCode 10| path=page.path The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received undefined

[mihailim]

This still happens and is still reproducible in the same way with 2.5.191.

[Chrisc-c-c]

Seems like the vast majority of bug reports have been closed without comment, but with a label of "migrate" attached. I wonder if this suggests the issue doesn't exist in version 3.

It would be nice to have some clarification on this @NGPixel.

[NGPixel]

@Chrisc-c-c Issues were simply converted to Discussions for easier management. Nothing was closed...

[Chrisc-c-c]

Oh right, thanks for the clarification. The confusion arose from the fact that GitHub sends out emails letting everyone know that the issue "has been closed" at the point of the conversion.

Is the process going forward to raise bug reports within discussions, rather than the "issues" section then?

[NGPixel]

Correct. Issues were getting out of hand and it was impossible to manage. Discussions are now the way to go. Once validated as a reproducible bug, an issue will be created and linked to the discussion.

[Chrisc-c-c]

Great, thanks for clarifying.

[mihailim]

This still happens and is still reproducible in the same way with 2.5.194.

To clarify: In order to reproduce, you must attempt to view the page source of a previous revision, not the current one (i.e. not the first one at the top of the list of revisions.) The current one works fine.

[PythonCoderAS]

This error still exists. It makes it really hard to view previous versions.

[mihailim]

This still happens exactly the same way with 2.5.214, regardless of node.js version, too.

[mihailim]

Same with 2.5.268, node 16.

[NGPixel]

Fixed by 92fe9d3

[mihailim]

Confirming, the patch solves the issue. Thank you so much!