Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1941] Remove test mode flag #2314

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[#1941] Remove test mode flag #2314

wants to merge 4 commits into from
+6 −65

Conversation

lyuanww
Copy link
Contributor

@lyuanww lyuanww commented Mar 3, 2025 •
edited
Loading

Fixes #1941

Proposed commit message

Remove test mode flag.

Currently, the test mode flag is not utilised in our codebase. The test
mode flag was added to pass system tests due to legacy reasons and the
related logic was removed in a previous PR.

Let's remove the related code and documentation for the test mode flag
to avoid additional maintenance.

@github-actions github-actions bot requested a deployment to dashboard-2314 March 3, 2025 04:48 Abandoned
@github-actions github-actions bot requested a deployment to docs-2314 March 3, 2025 04:48 Abandoned
@github-actions github-actions bot requested a deployment to dashboard-2314 March 3, 2025 05:35 Abandoned
@github-actions github-actions bot requested a deployment to docs-2314 March 3, 2025 05:35 Abandoned
@lyuanww lyuanww changed the title Remove test mode flag [#1941] Remove test mode flag Mar 3, 2025
@lyuanww lyuanww marked this pull request as ready for review March 3, 2025 05:50
@lyuanww lyuanww requested a review from a team March 3, 2025 09:21
CYX22222003
CYX22222003 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@CYX22222003 CYX22222003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR

@CYX22222003 CYX22222003 requested a review from a team March 6, 2025 09:22
joeng03
joeng03 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@joeng03 joeng03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sopa301
sopa301 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nitpick.

src/main/java/reposense/parser/ArgsParser.java Outdated
.help("Enables testing mode.");

argumentGroup.addArgument(FRESH_CLONING_FLAG)
parser.addArgument(FRESH_CLONING_FLAG)
.dest(FRESH_CLONING_FLAG[0])
.action(Arguments.storeTrue())
.help("Enables fresh cloning. Requires testing mode to be enabled.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.help("Enables fresh cloning. Requires testing mode to be enabled.");
.help("Enables fresh cloning.");

Now we don't have testing mode, I think we can remove this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeng03 joeng03 joeng03 approved these changes

@sopa301 sopa301 sopa301 approved these changes

@CYX22222003 CYX22222003 CYX22222003 approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removal of test mode flag in reposense code
4 participants
@lyuanww @joeng03 @sopa301 @CYX22222003