Skip to content

Fix packages with nix teams not showing up #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RossComputerGuy wants to merge 1 commit into from
Closed

Fix packages with nix teams not showing up #1492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions repology/parsers/parsers/nix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,13 @@ def iter_parse(self, path: str, factory: PackageFactory) -> Iterable[PackageMake
else:
pkg.add_maintainers(extract_nix_maintainers(meta['maintainers']))

if 'teams' in meta:
if not isinstance(meta['teams'], list):
Copy link
Copy Markdown
Member

@AMDmi3 AMDmi3 Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need data format checks, it should just fail on unexpected data. So this may probably be simplified to

for team in meta.get('teams', []):
    pkg.add_maintainers(extract_nix_maintainers(team['members']))

Copy link
Copy Markdown
Author

@RossComputerGuy RossComputerGuy Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pkg.log('teams "{}" is not a list'.format(meta['teams']), severity=Logger.ERROR)
else:
for item in meta['teams']:
pkg.add_maintainers(extract_nix_maintainers(item['members']))

if 'license' in meta:
pkg.add_licenses(extract_nix_licenses(meta['license']))

Expand Down