Ugrade phpstan to ^1.3 #531
Conversation
|
With no use of deprectaed Should I add an unit test on |
Yes please (in fact, this coverage is mainly for checking open source PR) ... or you can also lower it to 98% 🤷 |
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
============================================
- Coverage 99.33% 99.21% -0.12%
Complexity 1893 1893
============================================
Files 301 301
Lines 6013 6014 +1
============================================
- Hits 5973 5967 -6
- Misses 40 47 +7
Continue to review full report at Codecov.
|
akondas
force-pushed
the
upgrade-phpstan
branch
from
fb7fa6b to
fb8b9cd
Compare
|
Big thanks @alamirault 🍻 |
| @@ -53,7 +53,7 @@ public function getUsername() | |||
|
|
|||
| public function getUserIdentifier(): string | |||
| { | |||
| return $this->getUsername(); | |||
There was a problem hiding this comment.
Why did you make this change? I suppose we return the Organization alias here now, instead of the userIdentifier?
There was a problem hiding this comment.
getUsername is deprecated in symfony, phpstan extension for symfony now report it. In fact, getUsername return also alias so it's same
Phpstan 1.0.0 was released in november.
This PR use last version !
We may also add
@deprecatedannotation ongetUsernamemethods . It's deprecated in UserInterface since sf 5.3 in favor of getUserIdentifier()