Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explicitly cast to boolean #503

Merged
merged 2 commits into from
Aug 23, 2021
Merged

fix: Explicitly cast to boolean #503

merged 2 commits into from
Aug 23, 2021

Conversation

eFrane
Copy link
Contributor

@eFrane eFrane commented Aug 23, 2021

With strict type checking, passing a non-boolean as email scan result leads to a fatal error.

With strict type checking, passing a non-boolean as email scan result leads to a fatal error.
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #503 (15898d4) into master (f0d9e6a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 15898d4 differs from pull request most recent head adbd6b0. Consider uploading reports for the commit adbd6b0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master     #503   +/-   ##
=========================================
  Coverage     99.32%   99.32%           
  Complexity     1884     1884           
=========================================
  Files           300      300           
  Lines          5970     5970           
=========================================
  Hits           5930     5930           
  Misses           40       40           
Impacted Files Coverage Δ
src/Security/UserProvider.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d9e6a...adbd6b0. Read the comment docs.

@akondas
Copy link
Member

akondas commented Aug 23, 2021

Hi, thanks for contribution. Could you tell us how email_scan_result can have other value than bool? This value comes from database and is always bool ... or maybe I don't known something?

@eFrane
Copy link
Contributor Author

eFrane commented Aug 23, 2021

It is not bool when using a sqlite database. I know that this is not the recommended configuration, but it can't hurt to cast it anyway in my opinion.

@akondas akondas enabled auto-merge (squash) August 23, 2021 09:12
@akondas
Copy link
Member

akondas commented Aug 23, 2021

Thanks 👍

@akondas akondas merged commit 371bf79 into repman-io:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants