Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cargo clippy #507

Merged
merged 4 commits into from
Oct 29, 2024
Merged

fix: cargo clippy #507

merged 4 commits into from
Oct 29, 2024

Conversation

JeromeSchmied
Copy link

clippy fixes

I think these fixes improves code quality.

Note

unreadable_literal might also be usable, but I've excluded it for now.

command used:

cargo clippy -- \
    -W clippy::pedantic \
    -A clippy::cast_sign_loss \
    -A clippy::cast_possible_wrap \
    -A clippy::similar_names \
    -A clippy::must_use_candidate \
    -A clippy::return_self_not_must_use \
    -A clippy::cast_possible_truncation \
    -A clippy::default_trait_access \
    -A clippy::struct_excessive_bools \
    -A clippy::cast_lossless \
    -A clippy::wildcard_imports \
    -A clippy::cast_precision_loss \
    -A clippy::module_name_repetitions \
    -A clippy::unreadable_literal

@JeromeSchmied JeromeSchmied mentioned this pull request Oct 29, 2024
src/otp/migrations/mod.rs Outdated Show resolved Hide resolved
src/otp/otp_element.rs Outdated Show resolved Hide resolved
@replydev
Copy link
Owner

Hello @JeromeSchmied and thanks for your contributions!

As you may have noticed, the code has some tecnical debt and in the future may need a redesign to a better architecture.

Just two reviews, as I prefer to give the possibility to return errors on future migrations.

@JeromeSchmied
Copy link
Author

okay, I thought it was something like that, reverted.
and for the code, it's true that there are many-many things implemented which results in a huge code size i can see that well, but haven't really dove deep into it

@replydev
Copy link
Owner

Thanks @JeromeSchmied, gonna merge this.

@replydev replydev merged commit 4008f63 into replydev:main Oct 29, 2024
6 checks passed
Copy link
Contributor

github-actions bot commented Nov 4, 2024

🎉 This PR is included in version 1.9.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants