fix(scripts): catch and exit if building fails #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedeIlLeone
added
bug
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would have printed an error in the console but would have continued anyway saying that the building process went ok. With this PR instead if an error is caught by the building then we exit immeditately with a failure code 1. In this way the jobs of a workflow on GitHub also fail if something goes wrong.
https://discord.com/channels/1000926524452647132/1000955967627874424/1254504021570486302
The job would have ended successfully even if the building had not gone well, making the developer believe that the addon was ready.
Tested with various cases, even with watch.