[docker] One more attempt to make docker-compose happen#186
Merged
Conversation
lhchavez
requested review from
blast-hardcheese and
ryantm
and removed request for
a team and
blast-hardcheese
We had an attempt to make the reapers per-container, and that didn't quite work. This change now makes sure that every process creates a listener in a random-ish path and then inherits that to its children. No instance should ever stomp over the socket of another. And if a chain of processes set their own subprocess listeners, those are concatenated (although it's not strictly necessary, because setting a subreaper lower down the process tree should catch processes before their parents get a go at it).
lhchavez
force-pushed
the
lh-docker-per-process-subreaper-take-three
branch
from
4475aa4 to
e3d22f0
Compare
Replit doesn't use bridge networking, so let's force the use of host networking at every step of the way.
lhchavez
force-pushed
the
lh-docker-per-process-subreaper-take-three
branch
from
e3d22f0 to
60bda48
Compare
lhchavez
changed the title
ryantm
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We had an attempt to make the reapers per-container, and that didn't
quite work. buildkit also uses
bridgenetworking by default and thatdoesn't work in Replit.
What changed
This change:
random-ish path and then inherits that to its children. No instance
should ever stomp over the socket of another. And if a chain of
processes set their own subprocess listeners, those are concatenated
(although it's not strictly necessary, because setting a subreaper lower
down the process tree should catch processes before their parents get a
go at it).
Test plan
Now
docker buildanddocker-compose upboth work! (while fixing the latter, the former was broken). Also, buildkit mode works too!Rollout