Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore release 0.1.9 #23

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Restore release 0.1.9 #23

merged 1 commit into from
Feb 4, 2021

Conversation

TimoKramer
Copy link
Member

tests are unfortunately failing. @whilo any idea on why it is failing because of:

$ lein test
OpenJDK 64-Bit Server VM warning: forcing TieredStopAtLevel to full optimization because JVMCI is enabled
Syntax error (IllegalAccessError) compiling at (hitchhiker/konserve_test.cljc:1:1).
list-keys is not public

Full report at:
/tmp/clojure-15479272072895312237.edn
Tests failed.

@TimoKramer TimoKramer requested a review from whilo January 25, 2021 19:26
@whilo
Copy link
Member

whilo commented Jan 25, 2021

Unless we are ready to use konserve 0.6.0, we should not bump this dependency yet. If we want to start do so, we need to use the konserve.core/keys instead of list-keys function now, this is what the error is about.

@TimoKramer
Copy link
Member Author

For this PR I unpacked the hitchhiker-tree-0.1.9.jar from my local repo and copied it over the main branch. You can have a look at the pom in the 0.1.9 release that is already a few months old and there you can find

    <dependency>
      <groupId>io.replikativ</groupId>
      <artifactId>konserve</artifactId>
      <version>0.6.0-alpha1</version>
    </dependency>

In the jar there are no tests so I am not sure what to change in the tests to make it green.

@TimoKramer TimoKramer self-assigned this Jan 28, 2021
@TimoKramer TimoKramer changed the base branch from master to development February 4, 2021 17:33
@TimoKramer TimoKramer changed the base branch from development to master February 4, 2021 17:34
@TimoKramer
Copy link
Member Author

@groundedsage @whilo feel free to merge.

Copy link
Member

@whilo whilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @TimoKramer !

@whilo whilo merged commit 2360e8e into replikativ:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants