chore: add missing collectd package #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds `collectd-disk` on amazon linux 2023.
| @@ -5,3 +5,6 @@ yum8 collectd-disk | |||
| yum9 collectd | |||
| yum9 collectd-rrdtool | |||
| yum9 collectd-disk | |||
| yum2023 collectd | |||
There was a problem hiding this comment.
These lines got removed (very early in the process) when I locally ran:
pkg=dist/collectd-v5.tar.gz
make $pkg && tar xzvf $pkg
Because they got removed they were not commited when I raised the Amazon 2023 PR. I guess that it was happening due to some dangling files I had under build/, once I deleted the build/ directory it started to work as expected.
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5374-6734d5c-collectd-v5-k8s-docker-2024-08-28T10:38:45Z |
laverya
approved these changes
Aug 28, 2024
ricardomaraschini
deleted the
ricardomaraschini/sc-106636/add-missing-collectd-packages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
adds
collectd-diskon amazon linux 2023.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?