disable cri-containerd.apparmor.d on ubuntu 24.04 #5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5354-7c51e6b-containerd-1.6.33-k8s-ctrd-2024-08-22T22:16:47Z |
… and daily test cases also fix function name from 2024 to 2404
laverya
commented
Aug 23, 2024
Comment on lines
+198
to
+201
| if is_ubuntu_2404 ; then | ||
| # we need to disable apparmor on ubuntu 24.04 to allow pods to be deleted | ||
| sed -i 's/disable_apparmor = false/disable_apparmor = true/' /etc/containerd/config.toml | ||
| fi |
There was a problem hiding this comment.
I do not LIKE this solution
I think there is probably a better solution
I will keep looking for a better solution
This allows installations to complete in my testing
laverya
changed the title
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5354-6e9e8d5-containerd-1.6.33-k8s-ctrd-2024-08-23T01:15:16Z |
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5354-e2cb549-containerd-1.6.33-k8s-ctrd-2024-08-23T01:31:43Z |
sgalsaleh
approved these changes
Aug 23, 2024
laverya
deleted the
laverya/sc-105470/fix-ubuntu-2404-containerd-apparmor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this, pod deletions failed with errors like:
This was accompanied by dmesg logs like
Turning off
cri-containerd.apparmor.dentirely is a very blunt solution to this problem.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?