Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support bundle spec to velero addon 1.12.2 #5022

Merged
merged 6 commits into from
Jan 29, 2024
Merged

feat: Add support bundle spec to velero addon 1.12.2 #5022

merged 6 commits into from
Jan 29, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Jan 5, 2024

What this PR does / why we need it:

Install a velero support bundle spec whenever velero addon is added to a kURL spec.

Which issue(s) this PR fixes:

Fixes sc-67291

Special notes for your reviewer:

Steps to reproduce

Does this PR introduce a user-facing change?

Install a velero support bundle spec whenever velero addon is added to a kURL spec

Does this PR require documentation?

@banjoh banjoh requested a review from a team as a code owner January 5, 2024 19:42
@banjoh banjoh added the type::feature An enhancement to an existing add on or feature label Jan 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-f2e0787-velero-1.12.2-k8s-docker-2024-01-05T19:46:24Z

laverya
laverya requested changes Jan 5, 2024
View reviewed changes
addons/velero/1.12.2/tmpl-troubleshoot.yaml
Comment on lines +1 to +6
apiVersion: v1
kind: ConfigMap
metadata:
name: kurl-velero-supportbundle-spec
labels:
troubleshoot.io/kind: support-bundle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're creating this in the default namespace

either include this in the files applied by kustomize, or include the namespace here
I would recommend including this in the files applied by kustomize

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I'll create the config maps in the same namespace as the addons.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laverya I made the requested change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to approve - you need to add the kustomization change to the template files

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-60fe886-velero-1.12.2-k8s-docker-2024-01-08T10:39:28Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-ec48fd1-velero-1.12.0-k8s-docker-2024-01-08T10:56:23Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-ec48fd1-velero-1.12.1-k8s-docker-2024-01-08T10:56:25Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-ec48fd1-velero-1.12.2-k8s-docker-2024-01-08T10:56:33Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.9.2-k8s-docker-2024-01-09T12:19:55Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.9.5-k8s-docker-2024-01-09T12:20:03Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.9.3-k8s-docker-2024-01-09T12:20:24Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.9.4-k8s-docker-2024-01-09T12:21:07Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.9.1-k8s-docker-2024-01-09T12:21:22Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.8.1-k8s-docker-2024-01-09T12:23:22Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.9.0-k8s-docker-2024-01-09T12:23:22Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.7.1-k8s-docker-2024-01-09T12:24:23Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.12.2-k8s-docker-2024-01-09T12:27:35Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.12.1-k8s-docker-2024-01-09T12:28:12Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.11.1-k8s-docker-2024-01-09T12:28:39Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.11.0-k8s-docker-2024-01-09T12:30:24Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.10.2-k8s-docker-2024-01-09T12:31:13Z

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-0faacf6-velero-1.10.1-k8s-docker-2024-01-09T12:31:29Z

laverya
laverya reviewed Jan 9, 2024
View reviewed changes
addons/velero/1.9.5/tmpl-kustomization.yaml Outdated
@@ -2,3 +2,4 @@ namespace: ${VELERO_NAMESPACE}

resources:
- velero.yaml
- troubleshoot.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to make this change in template/base/tmpl-kustomization.yaml too, so it's included in future addon versions

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laverya change made

@banjoh banjoh force-pushed the em/velero-collector-analyser branch from a16af69 to e02562c Compare January 10, 2024 10:37
@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-bf6cf0a-velero-1.11.0-k8s-docker-2024-01-10T10:40:54Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-bf6cf0a-velero-1.12.1-k8s-docker-2024-01-10T10:41:04Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-bf6cf0a-velero-1.11.1-k8s-docker-2024-01-10T10:41:05Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-bf6cf0a-velero-1.12.0-k8s-docker-2024-01-10T10:41:06Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-bf6cf0a-velero-1.12.2-k8s-docker-2024-01-10T10:41:44Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-5af9279-velero-1.12.0-k8s-docker-2024-01-10T11:13:27Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-5af9279-velero-1.11.0-k8s-docker-2024-01-10T11:13:31Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-5af9279-velero-1.11.1-k8s-docker-2024-01-10T11:13:49Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-5af9279-velero-1.12.1-k8s-docker-2024-01-10T11:14:11Z

@github-actions GitHub Actions
Copy link
Contributor

Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5022-5af9279-velero-1.12.2-k8s-docker-2024-01-10T11:14:11Z

@xavpaice xavpaice requested a review from laverya January 29, 2024 05:24
@laverya laverya merged commit f6be88d into main Jan 29, 2024
@laverya laverya deleted the em/velero-collector-analyser branch January 29, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laverya laverya laverya approved these changes

Assignees
No one assigned
Labels
type::feature An enhancement to an existing add on or feature type::improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banjoh @laverya