bug: bump kurlkinds to 1.4.7 and fixes invalid hostpreflight operation #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR bumps kurlkinds to v1.4.7 and adapts the code to comply with the new hostpreflight type.
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-87845/installers-cluster-kurl-sh-crd-has-decode
branch
from
2dc2cf7 to
a1c543c
Compare
laverya
approved these changes
Aug 30, 2023
ricardomaraschini
deleted the
ricardomaraschini/sc-87845/installers-cluster-kurl-sh-crd-has-decode
branch
ricardomaraschini
added a commit
that referenced
this pull request
Sep 1, 2023
current stable kurl version does not work when we attempt to install and
patch the installer providing a custom hostpreflight. this is what happens
when we have attempt to patch the installer `installer-spec-file` flag:
```
$ cat patch.yaml
apiVersion: cluster.kurl.sh/v1beta1
kind: Installer
metadata:
name: installer
spec:
kurl:
hostPreflights:
apiVersion: troubleshoot.sh/v1beta2
kind: HostPreflight
spec:
collectors:
- http:
collectorName: Can Access Replicated API
get:
url: https://replicated.app
analyzers:
- http:
checkName: Can Access Replicated API
collectorName: Can Access Replicated API
outcomes:
- warn:
when: "error"
message: Error connecting to https://replicated.app
- pass:
when: "statusCode == 200"
message: Connected to https://replicated.app
- warn:
message: "Unexpected response"
$ curl https://kurl.sh/29035ee | sudo bash -s installer-spec-file=./patch.yaml
<redacted>
✔ Cluster Initialized
secret/kurl-troubleshoot-spec created
customresourcedefinition.apiextensions.k8s.io/installers.cluster.kurl.sh created
installer.cluster.kurl.sh/29035ee created
Error from server (BadRequest): error when creating "/tmp/kurl-bin-utils/specs/merged.yaml": Installer in version "v1beta1" cannot be handled as a Installer: strict decoding error: unknown field "spec.kurl.hostPreflights.metadata.creationTimestamp"
spent 1m attempting to run "kubectl apply -f /tmp/kurl-bin-utils/specs/merged.yaml" without success
```
this problem has been fixed by #4792
and this pr adds some tests to validate that:
1) we can install providing a custom host preflight.
2) once the cluster has been installed we can upgrade using a custom
host preflight.
ricardomaraschini
added a commit
that referenced
this pull request
Sep 1, 2023
current stable kurl version does not work when we attempt to install and
patch the installer providing a custom hostpreflight. this is what happens
when we have attempt to patch the installer `installer-spec-file` flag:
```
$ cat patch.yaml
apiVersion: cluster.kurl.sh/v1beta1
kind: Installer
metadata:
name: installer
spec:
kurl:
hostPreflights:
apiVersion: troubleshoot.sh/v1beta2
kind: HostPreflight
spec:
collectors:
- http:
collectorName: Can Access Replicated API
get:
url: https://replicated.app
analyzers:
- http:
checkName: Can Access Replicated API
collectorName: Can Access Replicated API
outcomes:
- warn:
when: "error"
message: Error connecting to https://replicated.app
- pass:
when: "statusCode == 200"
message: Connected to https://replicated.app
- warn:
message: "Unexpected response"
$ curl https://kurl.sh/29035ee | sudo bash -s installer-spec-file=./patch.yaml
<redacted>
✔ Cluster Initialized
secret/kurl-troubleshoot-spec created
customresourcedefinition.apiextensions.k8s.io/installers.cluster.kurl.sh created
installer.cluster.kurl.sh/29035ee created
Error from server (BadRequest): error when creating "/tmp/kurl-bin-utils/specs/merged.yaml": Installer in version "v1beta1" cannot be handled as a Installer: strict decoding error: unknown field "spec.kurl.hostPreflights.metadata.creationTimestamp"
spent 1m attempting to run "kubectl apply -f /tmp/kurl-bin-utils/specs/merged.yaml" without success
```
this problem has been fixed by #4792
and this pr adds some tests to validate that:
1) we can install providing a custom host preflight.
2) once the cluster has been installed we can upgrade using a custom
host preflight.
ricardomaraschini
added a commit
that referenced
this pull request
Sep 1, 2023
current stable kurl version does not work when we attempt to install and
patch the installer providing a custom hostpreflight. this is what happens
when we have attempt to patch the installer `installer-spec-file` flag:
```
$ cat patch.yaml
apiVersion: cluster.kurl.sh/v1beta1
kind: Installer
metadata:
name: installer
spec:
kurl:
hostPreflights:
apiVersion: troubleshoot.sh/v1beta2
kind: HostPreflight
spec:
collectors:
- http:
collectorName: Can Access Replicated API
get:
url: https://replicated.app
analyzers:
- http:
checkName: Can Access Replicated API
collectorName: Can Access Replicated API
outcomes:
- warn:
when: "error"
message: Error connecting to https://replicated.app
- pass:
when: "statusCode == 200"
message: Connected to https://replicated.app
- warn:
message: "Unexpected response"
$ curl https://kurl.sh/29035ee | sudo bash -s installer-spec-file=./patch.yaml
<redacted>
✔ Cluster Initialized
secret/kurl-troubleshoot-spec created
customresourcedefinition.apiextensions.k8s.io/installers.cluster.kurl.sh created
installer.cluster.kurl.sh/29035ee created
Error from server (BadRequest): error when creating "/tmp/kurl-bin-utils/specs/merged.yaml": Installer in version "v1beta1" cannot be handled as a Installer: strict decoding error: unknown field "spec.kurl.hostPreflights.metadata.creationTimestamp"
spent 1m attempting to run "kubectl apply -f /tmp/kurl-bin-utils/specs/merged.yaml" without success
```
this problem has been fixed by #4792
and this pr adds some tests to validate that:
1) we can install providing a custom host preflight.
2) once the cluster has been installed we can upgrade using a custom
host preflight.
ricardomaraschini
added a commit
that referenced
this pull request
Sep 1, 2023
current stable kurl version does not work when we attempt to install and
patch the installer providing a custom hostpreflight. this is what happens
when we have attempt to patch the installer `installer-spec-file` flag:
```
$ cat patch.yaml
apiVersion: cluster.kurl.sh/v1beta1
kind: Installer
metadata:
name: installer
spec:
kurl:
hostPreflights:
apiVersion: troubleshoot.sh/v1beta2
kind: HostPreflight
spec:
collectors:
- http:
collectorName: Can Access Replicated API
get:
url: https://replicated.app
analyzers:
- http:
checkName: Can Access Replicated API
collectorName: Can Access Replicated API
outcomes:
- warn:
when: "error"
message: Error connecting to https://replicated.app
- pass:
when: "statusCode == 200"
message: Connected to https://replicated.app
- warn:
message: "Unexpected response"
$ curl https://kurl.sh/29035ee | sudo bash -s installer-spec-file=./patch.yaml
<redacted>
✔ Cluster Initialized
secret/kurl-troubleshoot-spec created
customresourcedefinition.apiextensions.k8s.io/installers.cluster.kurl.sh created
installer.cluster.kurl.sh/29035ee created
Error from server (BadRequest): error when creating "/tmp/kurl-bin-utils/specs/merged.yaml": Installer in version "v1beta1" cannot be handled as a Installer: strict decoding error: unknown field "spec.kurl.hostPreflights.metadata.creationTimestamp"
spent 1m attempting to run "kubectl apply -f /tmp/kurl-bin-utils/specs/merged.yaml" without success
```
this problem has been fixed by #4792
and this pr adds some tests to validate that:
1) we can install providing a custom host preflight.
2) once the cluster has been installed we can upgrade using a custom
host preflight.
ricardomaraschini
added a commit
that referenced
this pull request
Sep 1, 2023
current stable kurl version does not work when we attempt to install and
patch the installer providing a custom hostpreflight. this is what happens
when we have attempt to patch the installer `installer-spec-file` flag:
```
$ cat patch.yaml
apiVersion: cluster.kurl.sh/v1beta1
kind: Installer
metadata:
name: installer
spec:
kurl:
hostPreflights:
apiVersion: troubleshoot.sh/v1beta2
kind: HostPreflight
spec:
collectors:
- http:
collectorName: Can Access Replicated API
get:
url: https://replicated.app
analyzers:
- http:
checkName: Can Access Replicated API
collectorName: Can Access Replicated API
outcomes:
- warn:
when: "error"
message: Error connecting to https://replicated.app
- pass:
when: "statusCode == 200"
message: Connected to https://replicated.app
- warn:
message: "Unexpected response"
$ curl https://kurl.sh/29035ee | sudo bash -s installer-spec-file=./patch.yaml
<redacted>
✔ Cluster Initialized
secret/kurl-troubleshoot-spec created
customresourcedefinition.apiextensions.k8s.io/installers.cluster.kurl.sh created
installer.cluster.kurl.sh/29035ee created
Error from server (BadRequest): error when creating "/tmp/kurl-bin-utils/specs/merged.yaml": Installer in version "v1beta1" cannot be handled as a Installer: strict decoding error: unknown field "spec.kurl.hostPreflights.metadata.creationTimestamp"
spent 1m attempting to run "kubectl apply -f /tmp/kurl-bin-utils/specs/merged.yaml" without success
```
this problem has been fixed by #4792
and this pr adds some tests to validate that:
1) we can install providing a custom host preflight.
2) once the cluster has been installed we can upgrade using a custom
host preflight.
ricardomaraschini
added a commit
that referenced
this pull request
Sep 5, 2023
* chore: adding test for hostpreflight installer merge
current stable kurl version does not work when we attempt to install and
patch the installer providing a custom hostpreflight. this is what happens
when we have attempt to patch the installer `installer-spec-file` flag:
```
$ cat patch.yaml
apiVersion: cluster.kurl.sh/v1beta1
kind: Installer
metadata:
name: installer
spec:
kurl:
hostPreflights:
apiVersion: troubleshoot.sh/v1beta2
kind: HostPreflight
spec:
collectors:
- http:
collectorName: Can Access Replicated API
get:
url: https://replicated.app
analyzers:
- http:
checkName: Can Access Replicated API
collectorName: Can Access Replicated API
outcomes:
- warn:
when: "error"
message: Error connecting to https://replicated.app
- pass:
when: "statusCode == 200"
message: Connected to https://replicated.app
- warn:
message: "Unexpected response"
$ curl https://kurl.sh/29035ee | sudo bash -s installer-spec-file=./patch.yaml
<redacted>
✔ Cluster Initialized
secret/kurl-troubleshoot-spec created
customresourcedefinition.apiextensions.k8s.io/installers.cluster.kurl.sh created
installer.cluster.kurl.sh/29035ee created
Error from server (BadRequest): error when creating "/tmp/kurl-bin-utils/specs/merged.yaml": Installer in version "v1beta1" cannot be handled as a Installer: strict decoding error: unknown field "spec.kurl.hostPreflights.metadata.creationTimestamp"
spent 1m attempting to run "kubectl apply -f /tmp/kurl-bin-utils/specs/merged.yaml" without success
```
this problem has been fixed by #4792
and this pr adds some tests to validate that:
1) we can install providing a custom host preflight.
2) once the cluster has been installed we can upgrade using a custom
host preflight.
* chore: adding grep to validate test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR bumps
kurlkindsto v1.4.7 and adapts the code to comply with the new HostPreflight type. The new HostPreflight type does not have an embedded ObjectMeta as this was causing some issues.