Catch cog.whl invalid filenames #1982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check if the cog wheel is an invalid filename from the point of view of pip install * Change the filename to conform to a valid pip filename.
|
I'd honestly much rather we fix the place that's generating incorrect wheels and building them into cog. That shouldn't be the case either with a dev build or with released versions of cog, and we should fix it if it is. |
|
Here's the packages artifact built for the 0.9.26 release. It's called |
|
Ok, well that wasn't too hard. This is the problem. |
|
I think we should probably aim to fix the Homebrew bottle build so it does the right thing rather than hack/patch it like this. |
|
This is now fixed: $ brew install cog
[...]
$ which cog
/opt/homebrew/bin/cog
$ strings $(which cog) | grep -Eo 'embed/.+.whl'
embed/cog-0.9.26-py3-none-any.whl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1963
I believe this was some kind of regression in #1873 however I am not entirely sure what. It's important to note that this does not occur on any development branches, I am quite sure this only occurs in release, but the mechanism as to how this occurs I am not entirely sure of. This in turn makes it hard to create a test case against and makes the code here defensive.