Fail prediction on unhandled error #1981
Merged
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the runner fails to handle an error this gets bubbled up to the worker, which logs a warning and then merrily carries on. Errors bubbling up in this way include things like failing to upload a file, which should fail the prediction. Currently if a model fails to upload one or more files for the prediction, the prediction will still be marked as succeeded, but it won't have any files in the output.
erbridge
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the runner fails to handle an error this gets bubbled up to the worker, which logs a warning and then merrily carries on. Errors bubbling up in this way include things like failing to upload a file, which should fail the prediction. Currently if a model fails to upload one or more files for the prediction, the prediction will still be marked as succeeded, but it won't have any files in the output.