Skip to content

Commit

Permalink
comment out dead code
Browse files Browse the repository at this point in the history
Signed-off-by: technillogue <[email protected]>
  • Loading branch information
technillogue committed Sep 1, 2023
1 parent 3e003be commit 8b06f58
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions pkg/dockerfile/generator.go
Original file line number Diff line number Diff line change
Expand Up @@ -251,18 +251,18 @@ func (g *Generator) baseImage() (string, error) {
return "python:" + g.Config.Build.PythonVersion + "-slim", nil
}

func (g *Generator) sitePackagesLocation() string {
// placing packages in workdir would make imports faster but can break some tests
// maybe more flags?
// TODO(sylv) maybe talk to fly about how to deal with experimental options like this
// if os.Getenv("INSTALL_PACKAGES_TO_WORKDIR") != "" { return "/src" }
py := g.Config.Build.PythonVersion
if g.Config.Build.GPU && g.useCudaBaseImage {
// ...
return "/root/.pyenv/versions/" + py + ".18/lib/python" + py + "/site-packages"
}
return "/usr/local/lib/python" + py + "/site-packages"
}
// func (g *Generator) sitePackagesLocation() string {
// // placing packages in workdir would make imports faster but can break some tests
// // maybe more flags?
// // TODO(sylv) maybe talk to fly about how to deal with experimental options like this
// // if os.Getenv("INSTALL_PACKAGES_TO_WORKDIR") != "" { return "/src" }
// py := g.Config.Build.PythonVersion
// if g.Config.Build.GPU && g.useCudaBaseImage {
// // ...
// return "/root/.pyenv/versions/" + py + ".18/lib/python" + py + "/site-packages"
// }
// return "/usr/local/lib/python" + py + "/site-packages"
// }

func (g *Generator) preamble() string {
return `ENV DEBIAN_FRONTEND=noninteractive
Expand Down

0 comments on commit 8b06f58

Please sign in to comment.