Skip to content

Parameterize next/return#30

Merged
brainkim merged 7 commits intomasterfrom
types
Oct 13, 2019
Merged

Parameterize next/return#30
brainkim merged 7 commits intomasterfrom
types

Conversation

@brainkim
Copy link
Collaborator

@brainkim brainkim commented Sep 3, 2019

Closes #17

  • Upgrades local typescript version to 3.6.2
  • Adds TReturn and TNext type parameters

TODO: figure out if we want to use the new IteratorResult/AsyncIterator type args. Doing this would force typescript users to use typescript 3.6.2 or later or provide their own type shim.

@brainkim
Copy link
Collaborator Author

brainkim commented Sep 4, 2019

Possibly blocked by microsoft/TypeScript#33239 unless we want to give up on implementing AsyncIterator

@brainkim
Copy link
Collaborator Author

Work on this has been unblocked by the release of typescript version 3.6.4

@brainkim brainkim marked this pull request as ready for review October 13, 2019 08:54
@brainkim brainkim merged commit 073b3ed into master Oct 13, 2019
@brainkim brainkim deleted the types branch October 16, 2019 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Repeater implement AsyncGenerator type and parameterize Return/Next types

1 participant