-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: identity caching + metrics #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto chris/ens-caching
…nto chris/identity-metrics
…nto chris/identity-metrics
arein
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only concern is the cardinality of the dimensions
Rakowskiii
approved these changes
Jun 22, 2023
I still need to do a few tweaks to get this right before merging:
|
…nto chris/identity-metrics
arein
approved these changes
Jun 26, 2023
Another problem I forgot to fix, but not critical: https://github.com/WalletConnect/rpc-relay/issues/5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds caching ENS lookups to Redis database.
Adds metrics publishing and new Grafana dashboards.
Also adds ability to deploy local changes to dev environment.
Also fixes hashicorp/terraform-provider-aws#28353
Resolves #191
Resolves #107
How Has This Been Tested?
Deployed to dev Terraform environment, made some lookups, checked Grafana charts. Tested against reown-com/appkit#1090
Due Diligence