-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix: make ConfigUtil
generic
#5073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
svenvoskamp
wants to merge
60
commits into
main
Choose a base branch
from
APKT-3730
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConfigUtil
more generic ConfigUtil
generic
Coverage Report
File Coverage
|
magiziz
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I refactored our current implementation with a generic and extensible architecture. The
ConfigUtil
will now support any feature flag that will come from the Cloud Dashboard.Type of change
Associated Issues
For Linear issues: Closes APKT-3730
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist
Note
Introduce a generic feature-bag builder (with aliasing and social_login transform) and refactor ConfigUtil to use it, updating types and tests accordingly.
config/build.ts
implementing a genericbuildFeatureBag
with:swap
→swaps
,history
→activity
).social_login
transformation intoemail
andsocials
.config/types.ts
definingJson
,FeatureBag
,Layer
,ApiEntry
.ConfigUtil.fetchRemoteFeatures
to usebuildFeatureBag
; simplify warning message generation and returnFeatureBag
.ConfigUtil.test.ts
expectations to new builder behavior, warning text, and key access patterns.Written by Cursor Bugbot for commit f2296a7. This will update automatically on new commits. Configure here.