Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing hover/active states on several components #2581

Merged
merged 33 commits into from
Jul 29, 2024

Conversation

svenvoskamp
Copy link
Contributor

Description

A lot of our hover/active states went missing over time due to css variables naming changes. Add these states again and adjusted several components.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests) NOTE: I think we should add UI tests for these cases ( https://www.chromatic.com )
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 29, 2024 4:31pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 29, 2024 4:31pm

@enesozturk enesozturk merged commit c1ae0a6 into main Jul 29, 2024
12 checks passed
@enesozturk enesozturk deleted the chore/hover-active-states branch July 29, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants