Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gets chains from approved accounts #2562

Merged
merged 5 commits into from
Jul 23, 2024
Merged

fix: gets chains from approved accounts #2562

merged 5 commits into from
Jul 23, 2024

Conversation

ganchoradkov
Copy link
Member

Description

Gets approved chains from the session accounts which are always present

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

https://walletconnect.slack.com/archives/C03RVH94K5K/p1721294190455089

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections

@ganchoradkov ganchoradkov requested a review from tomiir July 18, 2024 11:27
@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Jul 22, 2024 9:25pm
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Jul 22, 2024 9:25pm

quetool
quetool approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@quetool quetool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomiir tomiir merged commit 2f95f1a into main Jul 23, 2024
9 checks passed
@tomiir tomiir deleted the fix/get-chains-from-accounts branch July 23, 2024 00:09
@tomiir tomiir mentioned this pull request Jul 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomiir tomiir tomiir approved these changes

@quetool quetool quetool approved these changes

@glitch-txs glitch-txs Awaiting requested review from glitch-txs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganchoradkov @tomiir @quetool